[lib] Add action type for processing holders
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 6:21 AM.

Details

Reviewers

kamil
tomek

Commits

Summary

Added action types and updated reducer for the "process holders" action.

Holders are marked as PENDING_ESTABLISHMENT or PENDING_REMOVAL, before making Blob calls
Afterwards they're either removed or marked as ESTABLISHED.
In case of failure, all of them are marked as NOT_ESTABLISHED / NOT_REMOVED. This will be then handled by a handler component (introduced later) for retrying.

Depends on D13403

Test Plan

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

bartek published this revision for review.Sep 20 2024, 6:43 AM

lib/actions/holder-actions.js
14–23 ↗	(On Diff #44371)	Why aren't these types read-only?

kamil requested changes to this revision.Sep 20 2024, 8:16 AM

kamil added inline comments.

lib/actions/holder-actions.js
3–4 ↗	(On Diff #44371)
7 ↗	(On Diff #44371)	nit: I would remove `StoreEstablishedHolderPayload` and use `BlobHashAndHolder` directly
14–23 ↗	(On Diff #44371)
lib/reducers/holder-reducer.js
63 ↗	(On Diff #44371)	I think we should change this, update `PROCESS_HOLDERS_FAILED` to have failed hashes as payload (similar as here) and only those mark as failed. Additionally wondering, if we really need `pending` states after this.

This revision now requires changes to proceed.Sep 20 2024, 8:16 AM

lib/reducers/holder-reducer.js
66–71 ↗	(On Diff #44371)	Please avoid this: https://www.notion.so/commapp/Use-ternary-conditionals-sparingly-f4ba44a10259403592a1d15440a9847e

Updated types and failure action

This revision is now accepted and ready to land.Sep 23 2024, 5:09 AM

Newline

lib/reducers/holder-reducer.js
63 ↗	(On Diff #44371)	makes sense, thanks! Additionally wondering, if we really need pending states after this. Yes, we need it to avoid unnecessarily start processing new holders if they're already being processed (pending status)