Tags

None

Referenced Files

	F3570387: D13401.id44426.diff
	Sat, Dec 28, 5:05 AM

	F3570386: D13401.id44359.diff
	Sat, Dec 28, 5:05 AM

	F3570329: D13401.id.diff
	Sat, Dec 28, 5:05 AM

	F3570301: D13401.diff
	Sat, Dec 28, 5:04 AM

	Unknown Object (File)
	Nov 25 2024, 8:30 AM

	Unknown Object (File)
	Nov 25 2024, 6:31 AM

	Unknown Object (File)
	Nov 20 2024, 10:35 AM

	Unknown Object (File)
	Nov 20 2024, 10:35 AM

View All 41 Files

Subscribers

ashoat

Details

Reviewers

kamil
tomek

Commits

rCOMM924d5c321656: [lib] Prefix blob holders with device ID

Summary

Address ENG-9282.
Made multimedia blob holders prefixed by device ID.

Device ID is a base64-like string, which isn't a valid holder so used base64url conversion.

Test Plan

Successfully uploaded multimedia to a DM thread. Printed the

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 20 2024, 2:58 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 2:58 AM

Harbormaster completed remote builds in B31729: Diff 44359.Sep 20 2024, 3:15 AM

bartek added a child revision: D13403: [lib] Add reducer and action to store established holder.Sep 20 2024, 3:52 AM

bartek published this revision for review.Sep 20 2024, 3:53 AM

kamil accepted this revision.Sep 20 2024, 6:00 AM

This revision is now accepted and ready to land.Sep 20 2024, 6:00 AM

bartek mentioned this in D13410: [lib] Let blob holder generator take deviceID as argument.Sep 20 2024, 6:25 AM

Closed by commit rCOMM924d5c321656: [lib] Prefix blob holders with device ID (authored by bartek). · Explain WhySep 23 2024, 7:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM924d5c321656: [lib] Prefix blob holders with device ID.

bartek mentioned this in rCOMMa5b81199539a: [lib] Let blob holder generator take deviceID as argument.

[lib] Prefix blob holders with device ID
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44426

lib/actions/upload-actions.js

lib/utils/blob-service.js

[lib] Prefix blob holders with device IDClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44426

lib/actions/upload-actions.js

lib/utils/blob-service.js

[lib] Prefix blob holders with device ID
ClosedPublic
Actions

Revision Contents
Changeset List