Paths

Table of Contentst

Differential D13479

[blob] New endpoint to batch-delete holders
ClosedPublic
Actions

Authored by bartek on Thu, Sep 26, 12:19 AM.

Tags

None

Referenced Files

	F2840906: D13479.id44583.diff
	Sun, Sep 29, 8:36 AM

	Unknown Object (File)
	Fri, Sep 27, 7:16 AM

	Unknown Object (File)
	Fri, Sep 27, 7:05 AM

	Unknown Object (File)
	Fri, Sep 27, 7:05 AM

	Unknown Object (File)
	Thu, Sep 26, 1:18 AM

	Unknown Object (File)
	Thu, Sep 26, 1:15 AM

	Unknown Object (File)
	Thu, Sep 26, 1:11 AM

Subscribers

Details

Reviewers

will
kamil
marcin
tomek

Commits

rCOMM15722dd21581: [blob] New endpoint to batch-delete holders

Summary

Address ENG-4842.
Request and response format described in the Linear issue.

Created a new DELETE /holders endpoint for removing multiple holders in a single request.

Test Plan

Ran Blob locally. Called the endpoint using Postman and made sure holders are removed from DDB.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Sep 26, 12:19 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Sep 26, 12:19 AM

bartek added a child revision: D13480: [blob] New endpoint to batch-add holders.Thu, Sep 26, 12:23 AM

Harbormaster completed remote builds in B31865: Diff 44583.Thu, Sep 26, 12:36 AM

bartek published this revision for review.Thu, Sep 26, 12:46 AM

bartek edited reviewers, added: tomek; removed: varun.

bartek added inline comments.

services/blob/src/http/handlers/holders.rs
46	This has to be done sequentially in a loop because `service.revoke_holder()` makes a DDB transaction and these transactions could conflict with each other, e.g. if two holders were removed for the same blob hash. It is theoretically possible to make it one transaction but it's complicated and not worth doing as long as performance is okay

bartek mentioned this in D13480: [blob] New endpoint to batch-add holders.Thu, Sep 26, 12:52 AM

kamil accepted this revision.Fri, Sep 27, 2:36 AM

kamil added inline comments.

services/blob/src/http/handlers/holders.rs
46	worth adding as code comment

This revision is now accepted and ready to land.Fri, Sep 27, 2:36 AM

Closed by commit rCOMM15722dd21581: [blob] New endpoint to batch-delete holders (authored by bartek). · Explain WhyFri, Sep 27, 6:55 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM15722dd21581: [blob] New endpoint to batch-delete holders.

bartek mentioned this in D13510: [terraform] Bump staging Blob to 1.2.0.Sat, Sep 28, 1:22 AM

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

79 lines

8 lines

Diff 44583

services/blob/src/http/handlers/holders.rs

Loading...

services/blob/src/http/mod.rs

Loading...