Paths

Table of Contentst

Differential D13481

[blob] Batch check if blob exists
ClosedPublic
Actions

Authored by bartek on Thu, Sep 26, 12:35 AM.

Tags

None

Referenced Files

	F2840561: D13481.id44586.diff
	Sun, Sep 29, 6:21 AM

	F2840055: D13481.diff
	Sun, Sep 29, 4:45 AM

	F2840004: D13481.diff
	Sun, Sep 29, 4:23 AM

	Unknown Object (File)
	Fri, Sep 27, 7:25 AM

	Unknown Object (File)
	Fri, Sep 27, 7:06 AM

	Unknown Object (File)
	Thu, Sep 26, 3:38 PM

	Unknown Object (File)
	Thu, Sep 26, 1:18 AM

	Unknown Object (File)
	Thu, Sep 26, 1:15 AM

View All 10 Files

Subscribers

Details

Reviewers

will
varun
kamil
marcin

Commits

rCOMM36354e261080: [blob] Batch check if blob exists

Summary

Instead of calling GetItem for each blob (and get all its data) just to see if it exists, we can re-use db.list_existing_keys() which internally uses BatchGetItem to only get primary keys, all at once.
This improves DDB performance and reduces costs.

Updated batch-add-holders endpoint to use this.

Depends on D13480

Test Plan

Repeated test plan from D13480 confirmed it works the same way.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Sep 26, 12:35 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Sep 26, 12:35 AM

bartek added a child revision: D13482: [blob] Use new blob-exists check in single endpoint.Thu, Sep 26, 12:40 AM

Harbormaster completed remote builds in B31868: Diff 44586.Thu, Sep 26, 12:52 AM

bartek published this revision for review.Thu, Sep 26, 12:55 AM

bartek added inline comments.

services/blob/src/http/handlers/holders.rs
54–55 ↗	(On Diff #44586)	This part is updated in the next diff
services/blob/src/service.rs
289–291 ↗	(On Diff #44586)	This should work too

kamil accepted this revision.Fri, Sep 27, 2:45 AM

This revision is now accepted and ready to land.Fri, Sep 27, 2:45 AM

Closed by commit rCOMM36354e261080: [blob] Batch check if blob exists (authored by bartek). · Explain WhyFri, Sep 27, 6:55 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM36354e261080: [blob] Batch check if blob exists.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

10 lines

26 lines

Diff 44633

services/blob/src/http/handlers/holders.rs

Loading...

services/blob/src/service.rs

Loading...