Page MenuHomePhabricator
Differential D13547

[lib] Make sure we set isViewer in useExistingThreadInfoFinder
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 11:53 AM
Unknown Object (File)
Wed, Dec 18, 11:53 AM
Unknown Object (File)
Wed, Dec 18, 11:52 AM
Unknown Object (File)
Wed, Dec 18, 11:52 AM
Unknown Object (File)
Nov 21 2024, 6:23 PM
Unknown Object (File)
Nov 19 2024, 8:59 AM
Unknown Object (File)
Nov 19 2024, 8:58 AM
Unknown Object (File)
Nov 10 2024, 4:20 PM
View All 38 Files
Subscribers
None

Details

Reviewers
tomek
kamil
inka
Commits
rCOMM332eeeba691e: [lib] Make sure we set isViewer in useExistingThreadInfoFinder
Summary

When we call createPendingThread in useExistingThreadInfoFinder, we need to include isViewer in order to make sure a PRIVATE thread is rendered as eg. "ashoat" instead of "just you". This is because the naming is based on ifJustViewer, which only applies if the members list only includes the viewer.

Depends on D13546

Test Plan

Confirm that I see eg. "ashoat" instead of "just you" for PRIVATE thread uiName

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
5 lines

Diff 44728

View Options

lib/shared/thread-utils.js

Loading...