Page MenuHomePhabricator

[lib] Simplify useExistingThreadInfoFinder
ClosedPublic

Authored by ashoat on Sep 30 2024, 9:43 PM.
Tags
None
Referenced Files
F3311470: D13534.id44715.diff
Tue, Nov 19, 8:54 AM
F3305911: D13534.id44715.diff
Mon, Nov 18, 5:12 PM
Unknown Object (File)
Sun, Nov 10, 4:20 PM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Sun, Nov 3, 4:11 PM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Subscribers
None

Details

Summary

Since D13404, pendingToRealizedThreadIDsSelector will return the same thing when queried with a thin thread versus a thick thread.

As such, there's no longer a reason to check for both separately here.

Separately, I also got rid of the ternary at the end in favor of an early exit.

Depends on D13533

Test Plan

Careful reading of the code, as well as being tested with the rest of the stack, where I test all kinds of ways of creating a thread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable