Page MenuHomePhabricator

[web] Use PRIVATE instead of GENESIS_PRIVATE in baseThreadInfo passed to useExistingThreadInfoFinder
ClosedPublic

Authored by ashoat on Sep 30 2024, 10:12 PM.
Tags
None
Referenced Files
F3342048: D13553.id44734.diff
Fri, Nov 22, 12:19 AM
F3341338: D13553.id44735.diff
Thu, Nov 21, 10:51 PM
F3338357: D13553.diff
Thu, Nov 21, 6:02 PM
Unknown Object (File)
Sun, Nov 10, 4:21 PM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Unknown Object (File)
Fri, Nov 8, 3:00 AM
Subscribers
None

Details

Summary

When searching: true, useExistingThreadInfoFinder doesn't actually care about baseThreadInfo.type, as long as it passes threadTypeCanBePending. The only exception would be if the viewer is logged out, in which case the calling component should be in the process of being unmounted anyways.

Given that it doesn't matter, I'd prefer to use PRIVATE here instead of GENESIS_PRIVATE.

native changes aren't necessary because they were handled in D13253.

Depends on D13552

Test Plan

Careful code inspection, as well as the testing done in the rest of the stack: on both native and web, tested PRIVATE thread creation end-to-end via thread list search, chat composer, and user profile. Confirmed that a peer (same user device) receives the DM messages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable