Page MenuHomePhabricator
Differential D13907

[lib] Introduce a restore screen
AcceptedPublic
Actions

Authored by tomek on Tue, Nov 12, 6:15 AM.
Tags
None
Referenced Files
F3335954: D13907.id45751.diff
Thu, Nov 21, 12:53 PM
F3335921: D13907.id45841.diff
Thu, Nov 21, 12:27 PM
F3335278: D13907.id45747.diff
Thu, Nov 21, 8:52 AM
F3335261: D13907.id45750.diff
Thu, Nov 21, 8:45 AM
F3333902: D13907.id45840.diff
Thu, Nov 21, 5:23 AM
F3332861: D13907.id45749.diff
Thu, Nov 21, 2:21 AM
F3329567: D13907.diff
Wed, Nov 20, 5:30 PM
F3328669: D13907.id45797.diff
Wed, Nov 20, 2:35 PM
View All 47 Files
Subscribers
ashoat

Details

Reviewers
kamil
angelika
bartek
Summary

Add a new screen where a user can restore the account using a password or SIWE.

https://linear.app/comm/issue/ENG-9679/create-a-screen-where-user-can-choose-between-usernamepassword-and

The restore screen

restore-screen-3.png (2×1 px, 2 MB)

The prompt screen after this diff - no changes

prompt-after-restore.png (2×1 px, 1 MB)

Depends on D13906

Test Plan

Checked that this screen looks correctly and clicking the actions navigates to appropriate screens.

Diff Detail

Repository
rCOMM Comm
Branch
restore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Tue, Nov 12, 6:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Nov 12, 6:15 AM
tomek edited the summary of this revision. (Show Details)Tue, Nov 12, 6:15 AM
Harbormaster completed remote builds in B32613: Diff 45747.Tue, Nov 12, 7:07 AM
tomek requested review of this revision.Tue, Nov 12, 7:07 AM
tomek updated this revision to Diff 45750.Tue, Nov 12, 7:21 AM

Update the padding

tomek edited the summary of this revision. (Show Details)Tue, Nov 12, 7:21 AM
tomek updated this revision to Diff 45751.Tue, Nov 12, 7:22 AM

Format

ashoat added a comment.Tue, Nov 12, 7:25 AM
  1. I'm not sure the "OR" thing is necessary anymore now that we only have two buttons instead of three
  2. Can we replace "Sign in" with "Sign in with password"?
Harbormaster completed remote builds in B32615: Diff 45751.Tue, Nov 12, 7:41 AM
Harbormaster completed remote builds in B32614: Diff 45750.Tue, Nov 12, 7:50 AM
tomek updated this revision to Diff 45797.Wed, Nov 13, 7:08 AM

Update copy and remove "or" section

tomek edited the summary of this revision. (Show Details)Wed, Nov 13, 7:09 AM
Harbormaster completed remote builds in B32651: Diff 45797.Wed, Nov 13, 7:26 AM
tomek updated this revision to Diff 45840.Fri, Nov 15, 9:58 AM

Rebase

Harbormaster completed remote builds in B32678: Diff 45840.Fri, Nov 15, 10:23 AM
tomek added a child revision: D13946: [native] Update the QR login screen to mention the primary device.Fri, Nov 15, 10:24 AM
kamil accepted this revision.Tue, Nov 19, 1:33 AM
This revision is now accepted and ready to land.Tue, Nov 19, 1:33 AM

Revision Contents
Changeset List

PathSize
native/
account/
34 lines

Diff 45747

View Options

native/account/logged-out-modal.react.js

Loading...