Paths

Table of Contentst

[lib] Extract function to assign holder
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 2:52 PM.

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMMffdfcb7c95b8: [lib] Extract function to assign holder

Summary

Preparation for ENG-9526.
Replaced direct calls of fetch() with a dedicated function. It makes it easier to handle specific response code for invalid CSAT.

Depends on D13958

Test Plan

Flow, eslint, manual testing

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 18 2024, 2:52 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 2:52 PM

bartek added a child revision: D13960: [lib] Extract function to remove holder.Nov 18 2024, 2:52 PM

Harbormaster completed remote builds in B32700: Diff 45866.Nov 18 2024, 9:01 PM

bartek published this revision for review.Nov 21 2024, 12:28 PM

ashoat accepted this revision.Nov 22 2024, 12:45 AM

ashoat added inline comments.

keyserver/src/services/blob.js
116	I'm confused how this wasn't causing ESLint errors earlier
lib/utils/blob-service.js
148	Inputs should (usually) be read-only

This revision is now accepted and ready to land.Nov 22 2024, 12:45 AM

ashoat mentioned this in D13992: [native][web] Handle invalid CSAT in input-state-containers.Nov 25 2024, 1:52 PM

bartek added inline comments.Nov 26 2024, 12:10 PM

keyserver/src/services/blob.js
116	Answered in https://phab.comm.dev/D13989#inline-78783
lib/utils/blob-service.js
148	https://phab.comm.dev/D13958#inline-78842

Rebase

Harbormaster completed remote builds in B32838: Diff 46053.Nov 26 2024, 12:29 PM

Thanks for explaining!

Closed by commit rCOMMffdfcb7c95b8: [lib] Extract function to assign holder. · Explain WhyNov 29 2024, 1:02 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMffdfcb7c95b8: [lib] Extract function to assign holder.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

blob.js

24 lines

lib/

actions/

upload-actions.js

52 lines

utils/

blob-service.js

32 lines

services-utils.js

8 lines

Diff 45866

View Options

keyserver/src/services/blob.js

View Options

lib/actions/upload-actions.js

View Options

lib/utils/blob-service.js

View Options

lib/utils/services-utils.js

[lib] Extract function to assign holderClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45866

keyserver/src/services/blob.js

lib/actions/upload-actions.js

lib/utils/blob-service.js

lib/utils/services-utils.js

[lib] Extract function to assign holder
ClosedPublic
Actions

Revision Contents
Changeset List