[native] Move button expansion logic in ChatInputBar to function component
ClosedPublic
Actions

Authored by angelika on Nov 22 2024, 4:36 AM.

Details

Reviewers

kamil
bartek
ashoat

Commits

rCOMM4af634331c67: [native] Move button expansion logic in ChatInputBar to function component

Summary

https://linear.app/comm/issue/ENG-8147/convert-chatinputbar-to-reanimated-2-syntax

Depends on D14009

Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

focus the text input and verify the keyboard is up and the camera buttons are animated correctly
try to send the message, verify the send button is animated correctly
verify the text input can be unfocused and keyboard is hidden
verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
verify the edit mode works by editing a message
try to close the chat while editing a message - the alert should be shown
try to join a thread
try to select typed text

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Nov 22 2024, 4:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 22 2024, 4:36 AM

angelika added a child revision: D14011: [native] Move text input refs in ChatInputBar to function component.Nov 22 2024, 4:37 AM

Harbormaster completed remote builds in B32774: Diff 45950.Nov 22 2024, 5:14 AM

angelika requested review of this revision.Nov 22 2024, 5:14 AM

ashoat accepted this revision.Nov 23 2024, 10:48 AM

ashoat added inline comments.

native/chat/chat-input-bar.react.js
319	Looks like you could remove this from the class component's props at this point, but I suppose you'll do that in a later diff?

This revision is now accepted and ready to land.Nov 23 2024, 10:48 AM

Rebase

Harbormaster failed remote builds in B32817: Diff 46026!Nov 25 2024, 7:33 AM

Fix rebase

Harbormaster completed remote builds in B32853: Diff 46068.Nov 26 2024, 6:47 AM

Closed by commit rCOMM4af634331c67: [native] Move button expansion logic in ChatInputBar to function component (authored by angelika). · Explain WhyNov 28 2024, 5:12 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM4af634331c67: [native] Move button expansion logic in ChatInputBar to function component.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

188 lines

Diff 45950

View Options

native/chat/chat-input-bar.react.js

	// @flow			// @flow

	import type {			import type {
	MessageReportCreationRequest,			MessageReportCreationRequest,
	MessageReportCreationResult,			MessageReportCreationResult,
	} from '../types/message-report-types.js';			} from '../types/message-report-types.js';
	import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';			import { extractKeyserverIDFromID } from '../utils/action-utils.js';
				import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';
				import { useKeyserverCall } from '../utils/keyserver-call.js';

	const sendMessageReportActionTypes = Object.freeze({			const sendMessageReportActionTypes = Object.freeze({
	started: 'SEND_MESSAGE_REPORT_STARTED',			started: 'SEND_MESSAGE_REPORT_STARTED',
	success: 'SEND_MESSAGE_REPORT_SUCCESS',			success: 'SEND_MESSAGE_REPORT_SUCCESS',
	failed: 'SEND_MESSAGE_REPORT_FAILED',			failed: 'SEND_MESSAGE_REPORT_FAILED',
	});			});
	const sendMessageReport =			const sendMessageReport =
	(			(
	callServerEndpoint: CallServerEndpoint,			callKeyserverEndpoint: CallKeyserverEndpoint,
	): ((			): ((
	request: MessageReportCreationRequest,			input: MessageReportCreationRequest,
	) => Promise<MessageReportCreationResult>) =>			) => Promise<MessageReportCreationResult>) =>
	async request => {			async input => {
	return await callServerEndpoint('create_message_report', request);			const keyserverID = extractKeyserverIDFromID(input.messageID);
				const requests = { [keyserverID]: input };

				const responses = await callKeyserverEndpoint(
				'create_message_report',
				requests,
				);
				const response = responses[keyserverID];

				return { messageInfo: response.messageInfo };
	};			};

	export { sendMessageReportActionTypes, sendMessageReport };			function useSendMessageReport(): (
				input: MessageReportCreationRequest,
				) => Promise<MessageReportCreationResult> {
				return useKeyserverCall(sendMessageReport);
				}

				export { sendMessageReportActionTypes, useSendMessageReport };

[native] Move button expansion logic in ChatInputBar to function componentClosedPublicActions