Page MenuHomePhabricator

[native] Move join thread functions in ChatInputBar to function component
ClosedPublic

Authored by angelika on Nov 22 2024, 4:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 6:32 AM
Unknown Object (File)
Wed, Jan 8, 4:47 AM
Unknown Object (File)
Sun, Dec 29, 1:48 AM
Unknown Object (File)
Sat, Dec 28, 4:12 PM
Unknown Object (File)
Sat, Dec 28, 12:35 AM
Unknown Object (File)
Sat, Dec 28, 12:35 AM
Unknown Object (File)
Sat, Dec 28, 12:34 AM
Unknown Object (File)
Fri, Dec 27, 12:53 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
1413

I think it would be good to have the callJoinThread declaration next to this

This revision is now accepted and ready to land.Nov 24 2024, 6:33 PM