[lib] Extract function to assign holder
ClosedPublic
Actions

Authored by bartek on Nov 18 2024, 6:52 AM.

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMMffdfcb7c95b8: [lib] Extract function to assign holder

Summary

Preparation for ENG-9526.
Replaced direct calls of fetch() with a dedicated function. It makes it easier to handle specific response code for invalid CSAT.

Depends on D13958

Test Plan

Flow, eslint, manual testing

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 18 2024, 6:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 18 2024, 6:52 AM

bartek added a child revision: D13960: [lib] Extract function to remove holder.Nov 18 2024, 6:52 AM

Harbormaster completed remote builds in B32700: Diff 45866.Nov 18 2024, 1:01 PM

bartek published this revision for review.Nov 21 2024, 4:28 AM

ashoat accepted this revision.Nov 21 2024, 4:45 PM

ashoat added inline comments.

keyserver/src/services/blob.js
116 ↗	(On Diff #45866)	I'm confused how this wasn't causing ESLint errors earlier
lib/utils/blob-service.js
148 ↗	(On Diff #45866)	Inputs should (usually) be read-only

This revision is now accepted and ready to land.Nov 21 2024, 4:45 PM

ashoat mentioned this in D13992: [native][web] Handle invalid CSAT in input-state-containers.Mon, Nov 25, 5:52 AM

bartek added inline comments.Tue, Nov 26, 4:10 AM

keyserver/src/services/blob.js
116 ↗	(On Diff #45866)	Answered in https://phab.comm.dev/D13989#inline-78783
lib/utils/blob-service.js
148 ↗	(On Diff #45866)	https://phab.comm.dev/D13958#inline-78842