Page MenuHomePhabricator

[native] Move navigation related callbacks in ChatInputBar to function component
ClosedPublic

Authored by angelika on Nov 22 2024, 4:39 AM.
Tags
None
Referenced Files
F3738595: D14013.id46117.diff
Thu, Jan 9, 9:28 AM
F3736542: D14013.id46030.diff
Thu, Jan 9, 6:14 AM
F3735003: D14013.id46118.diff
Thu, Jan 9, 4:02 AM
F3731523: D14013.id45953.diff
Thu, Jan 9, 12:42 AM
Unknown Object (File)
Wed, Jan 8, 4:51 AM
Unknown Object (File)
Wed, Jan 8, 3:12 AM
Unknown Object (File)
Tue, Jan 7, 11:13 AM
Unknown Object (File)
Tue, Jan 7, 10:37 AM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
1350–1358 ↗(On Diff #45953)

Would it make sense to define this right before unblockNavigation?

1404 ↗(On Diff #45953)

Nit: I think this has the same effect

This revision is now accepted and ready to land.Nov 24 2024, 6:31 PM