Page MenuHomePhabricator

[native] Move join thread functions in ChatInputBar to function component
ClosedPublic

Authored by angelika on Fri, Nov 22, 4:41 AM.
Tags
None
Referenced Files
F3387040: D14015.diff
Fri, Nov 29, 7:22 AM
F3386644: D14015.id45956.diff
Fri, Nov 29, 5:30 AM
Unknown Object (File)
Wed, Nov 27, 10:02 AM
Unknown Object (File)
Wed, Nov 27, 3:48 AM
Unknown Object (File)
Tue, Nov 26, 8:56 PM
Unknown Object (File)
Tue, Nov 26, 8:56 PM
Unknown Object (File)
Tue, Nov 26, 8:56 PM
Unknown Object (File)
Tue, Nov 26, 8:56 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
1413 ↗(On Diff #45955)

I think it would be good to have the callJoinThread declaration next to this

This revision is now accepted and ready to land.Sun, Nov 24, 6:33 PM