Page MenuHomePhabricator

[native] Move button expansion logic in ChatInputBar to function component
ClosedPublic

Authored by angelika on Fri, Nov 22, 4:36 AM.
Tags
None
Referenced Files
F3397746: D14010.id46114.diff
Sun, Dec 1, 7:17 PM
Unknown Object (File)
Sat, Nov 30, 1:01 PM
Unknown Object (File)
Fri, Nov 29, 3:55 PM
Unknown Object (File)
Fri, Nov 29, 2:35 PM
Unknown Object (File)
Fri, Nov 29, 1:28 AM
Unknown Object (File)
Wed, Nov 27, 2:04 PM
Unknown Object (File)
Tue, Nov 26, 1:37 AM
Unknown Object (File)
Mon, Nov 25, 11:27 PM
Subscribers

Details

Summary
Test Plan

Tested this diff stack by playing around with ChatInputBar on both iOS simulator and Android device:

  • focus the text input and verify the keyboard is up and the camera buttons are animated correctly
  • try to send the message, verify the send button is animated correctly
  • verify the text input can be unfocused and keyboard is hidden
  • verify the draft works: write text, navigate from the chat, navigate into the chat again, verify the text is kept and the $
  • verify the edit mode works by editing a message
  • try to close the chat while editing a message - the alert should be shown
  • try to join a thread
  • try to select typed text

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/chat/chat-input-bar.react.js
319 ↗(On Diff #45950)

Looks like you could remove this from the class component's props at this point, but I suppose you'll do that in a later diff?

This revision is now accepted and ready to land.Sat, Nov 23, 10:48 AM