[native] Extract the buttons from the logged out modal
Needs ReviewPublic
Actions

Authored by tomek on Fri, Nov 29, 2:51 AM.

Details

Reviewers

kamil
angelika

Summary

These buttons will be used later in the stack. In theory, we could use the primary button for most of the cases, but the SIWE button is quite unique so it's safer to keep the current styling.

Depends on D14064

Test Plan

Check if the logged out modal still looks correct.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Fri, Nov 29, 2:51 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 29, 2:51 AM

tomek added inline comments.Fri, Nov 29, 2:57 AM

native/account/logged-out-modal.react.js
181	This prop isn't needed - the `button` style already specifies it

tomek edited the summary of this revision. (Show Details)Fri, Nov 29, 2:58 AM

tomek added inline comments.Fri, Nov 29, 3:01 AM

native/account/logged-out-modal.react.js
561	We don't have a list of register buttons anymore so we don't need to set this `key`

Harbormaster completed remote builds in B32895: Diff 46126.Fri, Nov 29, 3:10 AM

tomek requested review of this revision.Fri, Nov 29, 3:10 AM

tomek removed a parent revision: D14064: [native] Make QR screen style consistent with the registration flow.Fri, Nov 29, 4:05 AM

tomek edited the summary of this revision. (Show Details)

tomek added a parent revision: D14064: [native] Make QR screen style consistent with the registration flow.

tomek added a child revision: D13907: [native] Introduce a restore screen.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

102 lines

prompt-button.react.js

99 lines

Diff 46126

View Options

native/account/logged-out-modal.react.js