Paths

Table of Contentst

Differential D14066

[native] Extract the buttons from the logged out modal
ClosedPublic
Actions

Authored by tomek on Nov 29 2024, 2:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 14, 6:27 AM

	Unknown Object (File)
	Fri, Jan 10, 8:09 PM

	Unknown Object (File)
	Thu, Jan 9, 2:56 PM

	Unknown Object (File)
	Thu, Jan 9, 2:56 PM

	Unknown Object (File)
	Thu, Jan 9, 2:56 PM

	Unknown Object (File)
	Thu, Jan 9, 2:56 PM

	Unknown Object (File)
	Thu, Jan 9, 2:55 PM

	Unknown Object (File)
	Mon, Jan 6, 4:53 PM

View All 48 Files

Subscribers

Details

Reviewers

angelika
ashoat
kamil

Commits

rCOMMb298be8faf64: [native] Extract the buttons from the logged out modal

Summary

These buttons will be used later in the stack. Use the primary buttons instead of the old styling.

Before

old-buttons.png (2×1 px, 1 MB)

After

new-buttons.png (2×1 px, 1 MB)

Depends on D14064

Test Plan

Check if the logged out modal still looks correct.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Nov 29 2024, 2:51 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 29 2024, 2:51 AM

tomek added inline comments.Nov 29 2024, 2:57 AM

native/account/logged-out-modal.react.js
181	This prop isn't needed - the `button` style already specifies it

tomek edited the summary of this revision. (Show Details)Nov 29 2024, 2:58 AM

tomek added inline comments.Nov 29 2024, 3:01 AM

native/account/logged-out-modal.react.js
561	We don't have a list of register buttons anymore so we don't need to set this `key`

Harbormaster completed remote builds in B32895: Diff 46126.Nov 29 2024, 3:10 AM

tomek requested review of this revision.Nov 29 2024, 3:10 AM

tomek removed a parent revision: D14064: [native] Make QR screen style consistent with the registration flow.Nov 29 2024, 4:05 AM

tomek edited the summary of this revision. (Show Details)

tomek edited the summary of this revision. (Show Details)

tomek added a parent revision: D14064: [native] Make QR screen style consistent with the registration flow.

tomek added a child revision: D13907: [native] Introduce a restore screen.

kamil accepted this revision.Dec 2 2024, 1:09 AM

This revision is now accepted and ready to land.Dec 2 2024, 1:09 AM

Use the primary button

tomek edited the summary of this revision. (Show Details)Dec 4 2024, 7:21 AM

tomek added inline comments.

native/account/logged-out-modal.react.js
478–485 ↗	(On Diff #46209)	We could use `gap` if we had RN 0.71.

tomek requested review of this revision.Dec 4 2024, 7:23 AM

tomek added inline comments.Dec 4 2024, 7:26 AM

native/account/logged-out-modal.react.js
458–463 ↗	(On Diff #46209)	I wasn't sure if we should use the new design (consistent with the registration flow) or the old. If we decide to keep the old one, we can bring back the styling here, and use the `PromptButton` in the restoration flow.

Harbormaster completed remote builds in B32925: Diff 46209.Dec 4 2024, 7:37 AM

Specify the keys

Harbormaster completed remote builds in B32929: Diff 46213.Dec 5 2024, 1:56 AM

tomek added a reviewer: ashoat.Dec 6 2024, 2:40 AM

In this revision, styles are updated, so leaving this @ashoat for review

ashoat accepted this revision.Dec 7 2024, 12:54 PM

This revision is now accepted and ready to land.Dec 7 2024, 12:54 PM

tomek edited the summary of this revision. (Show Details)Dec 10 2024, 9:33 AM

Closed by commit rCOMMb298be8faf64: [native] Extract the buttons from the logged out modal (authored by tomek). · Explain WhyDec 10 2024, 10:12 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb298be8faf64: [native] Extract the buttons from the logged out modal.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

102 lines

prompt-button.react.js

99 lines

Diff 46126

native/account/logged-out-modal.react.js

Loading...

native/account/prompt-button.react.js

Loading...