This adds embeds as a parameter to the postCast method for the neynar client and makes text optional
Depends on D14086
Details
Details
Tested later in the stack. Was able to successfully post the frame url to warpcast
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 326–331 ↗ | (On Diff #46256) | Unsure if including undefined as an argument here is fine. The text parameter for postCast is optional. I found another example of us doing this in a call to persistCryptoStore in web/shared-worker/worker/worker-crypto.js: await persistCryptoStore(undefined, true); |
| lib/utils/neynar-client.js | ||
|---|---|---|
| 349–352 ↗ | (On Diff #46256) | Can we turn this into a "bag of params" instead? (Basically have it take one param, which is an object that can contain four properties) async postCast(
params: {
+signerUUID: string,
+parent: string,
+embeds?: ?$ReadOnlyArray<{ +url: string }>,
+text?: ?string,
}
): Promise<NeynarPostCastResponse> { |
| 351 ↗ | (On Diff #46256) | You're missing a + |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 326–331 ↗ | (On Diff #46256) | This will get addressed by the bag of params approach outlined below. Including in next rebase |
| lib/utils/neynar-client.js | ||
| 349–352 ↗ | (On Diff #46256) | Yeah. Unsure if we have a strict coding standard but it sounds like whenever we have four or more parameters for a function (or optional parameters), we should consider using a bag of params. Makes it easier to read function calls I'll include this in the next rebase |
| lib/utils/neynar-client.js | ||
|---|---|---|
| 349–352 ↗ | (On Diff #46256) | No strict rules, but 4 is a good guideline |