Page MenuHomePhabricator

[native] Fall back to v1 login when the user doesn't have a backup
Needs ReviewPublic

Authored by tomek on Fri, Dec 20, 9:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 11:36 AM
Unknown Object (File)
Mon, Dec 30, 10:16 AM
Unknown Object (File)
Sat, Dec 28, 5:42 PM
Unknown Object (File)
Fri, Dec 27, 5:24 AM
Unknown Object (File)
Fri, Dec 27, 1:04 AM
Unknown Object (File)
Fri, Dec 27, 12:43 AM
Unknown Object (File)
Thu, Dec 26, 9:58 PM
Unknown Object (File)
Thu, Dec 26, 8:43 PM
Subscribers

Details

Reviewers
kamil
bartek
Summary

Check if the user has a backup. When they don't have it, use the v1 login flow.

https://linear.app/comm/issue/ENG-9620/client-restore-flow-fall-back-to-v1-when-missing-backup

Depends on D14165

Test Plan

Because pf https://linear.app/comm/issue/ENG-10039/allow-checking-if-a-user-has-a-backup I had to hack it a bit: instead of calling retrieveLatestBackupInfo I hardcoded its return value to null. Then for both password and SIWE user verified that it is possible to log in.

Diff Detail

Repository
rCOMM Comm
Branch
restore4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Fri, Dec 20, 9:22 AM
native/account/restore-password-account-screen.react.js
52

At some point we'll probably want to rename usePasswordLogIn (and associated hooks) to reflect that they are v1 / legacy