Page MenuHomePhabricator
Differential D14421

[native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet
ClosedPublic
Actions

Authored by varun on Feb 27 2025, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 10:33 PM
Unknown Object (File)
Wed, Apr 2, 12:10 PM
Unknown Object (File)
Wed, Apr 2, 9:26 AM
Unknown Object (File)
Tue, Apr 1, 6:21 PM
Unknown Object (File)
Mon, Mar 31, 1:09 PM
Unknown Object (File)
Sat, Mar 29, 12:32 PM
Unknown Object (File)
Fri, Mar 28, 11:37 PM
Unknown Object (File)
Fri, Mar 28, 11:34 PM
View All 25 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM9c332325400a: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal…
Summary

If the user opened the modal by accepting the bottom sheet prompt, we'll still want to show them the nux tip when they close the modal so that they can find it in the future.

Depends on D14420

Test Plan

when i open the modal from the community drawer and then close it, nothing happens.

but if i open the modal from the bottom sheet and then close it, i see the NUX tip indicating where to find the directory

Diff Detail

Repository
rCOMM Comm
Branch
directory (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 27 2025, 10:42 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 27 2025, 10:42 PM
varun published this revision for review.Feb 28 2025, 2:48 PM

CI has been stuck for a day

ashoat requested changes to this revision.Feb 28 2025, 3:32 PM

Passing back to you with a question about why we avoid goBack when showing the NUX tip

native/components/community-joiner-modal.react.js
202

Should we extract navigate and goBack like we do in D14420?

207

I'm confused why we don't goBack before showing the NUX tip. Is it because the NUX tip replaces the CommunityJoinerModal? If that's the case, how come it doesn't apply to D14420, where we call goBack before navigate?

This revision now requires changes to proceed.Feb 28 2025, 3:32 PM
varun added inline comments.Mar 1 2025, 9:01 AM
native/components/community-joiner-modal.react.js
207

we don't need to call goBack in onCloseOrPressDecline in D14420. i'll remove it there

ashoat accepted this revision.Mar 1 2025, 12:55 PM
ashoat added inline comments.
native/components/community-joiner-modal.react.js
207

Okay, got it

This revision is now accepted and ready to land.Mar 1 2025, 12:55 PM
This revision was landed with ongoing or failed builds.Mar 1 2025, 2:25 PM
Closed by commit rCOMM9c332325400a: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal… (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM9c332325400a: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal….

Revision Contents
Changeset List

Diff 47298

View Options

native/components/community-joiner-modal.react.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>; fn get_backup_directory_path() -> Result<String>;
#[allow(unused)] #[allow(unused)]
#[cxx_name = "getBackupFilePath"] #[cxx_name = "getBackupFilePath"]
fn get_backup_file_path( fn get_backup_file_path(
backup_id: String, backup_id: String,
is_attachments: bool, is_attachments: bool,
) -> Result<String>; ) -> Result<String>;
#[allow(unused)]
#[cxx_name = "createMainCompaction"]
fn create_main_compaction(backup_id: String) -> Result<()>;
#[allow(unused)]
#[cxx_name = "restoreFromMainCompaction"]
fn restore_from_main_compaction(
main_compaction_path: String,
main_compaction_encryption_key: String,
) -> Result<()>;
} }
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines
View Options

native/components/directory-prompt-bottom-sheet.react.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>; fn get_backup_directory_path() -> Result<String>;
#[allow(unused)] #[allow(unused)]
#[cxx_name = "getBackupFilePath"] #[cxx_name = "getBackupFilePath"]
fn get_backup_file_path( fn get_backup_file_path(
backup_id: String, backup_id: String,
is_attachments: bool, is_attachments: bool,
) -> Result<String>; ) -> Result<String>;
#[allow(unused)]
#[cxx_name = "createMainCompaction"]
fn create_main_compaction(backup_id: String) -> Result<()>;
#[allow(unused)]
#[cxx_name = "restoreFromMainCompaction"]
fn restore_from_main_compaction(
main_compaction_path: String,
main_compaction_encryption_key: String,
) -> Result<()>;
} }
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines
View Options

native/components/modal.react.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>; fn get_backup_directory_path() -> Result<String>;
#[allow(unused)] #[allow(unused)]
#[cxx_name = "getBackupFilePath"] #[cxx_name = "getBackupFilePath"]
fn get_backup_file_path( fn get_backup_file_path(
backup_id: String, backup_id: String,
is_attachments: bool, is_attachments: bool,
) -> Result<String>; ) -> Result<String>;
#[allow(unused)]
#[cxx_name = "createMainCompaction"]
fn create_main_compaction(backup_id: String) -> Result<()>;
#[allow(unused)]
#[cxx_name = "restoreFromMainCompaction"]
fn restore_from_main_compaction(
main_compaction_path: String,
main_compaction_encryption_key: String,
) -> Result<()>;
} }
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines