Paths

Table of Contentst

[lib][native] Keep keyserver in device list after primary logout
ClosedPublic
Actions

Authored by bartek on Mar 27 2025, 9:24 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout

Summary

Address ENG-10231.
Despite being used only in usePrimaryDeviceLogOut(), I had to add selector to useBaseLogOut to avoid significant changes in logout hooks signatures. I can do a bigger refactor if requested.

Depends on D14491

Test Plan

Tested on staging together with D14490 and D14501.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 27 2025, 9:24 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 27 2025, 9:24 AM

bartek added a child revision: D14507: [lib] Don't send logout message to keyserver.Mar 27 2025, 9:29 AM

Simplify code and Flow null-checks

Harbormaster completed remote builds in B33851: Diff 47579.Mar 27 2025, 9:46 AM

Harbormaster completed remote builds in B33853: Diff 47581.Mar 27 2025, 9:53 AM

bartek published this revision for review.Mar 27 2025, 10:15 AM

kamil accepted this revision.Mar 27 2025, 10:37 AM

This revision is now accepted and ready to land.Mar 27 2025, 10:37 AM

Closed by commit rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout. · Explain WhyMar 27 2025, 12:23 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMfc01ada1f576: [lib][native] Keep keyserver in device list after primary logout.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

20 lines

shared/

device-list-utils.js

6 lines

types/

identity-service-types.js

2 lines

native/

identity-service/

identity-service-context-provider.react.js

8 lines

Diff 47579

View Options

lib/actions/user-actions.js

View Options

lib/shared/device-list-utils.js

View Options

lib/types/identity-service-types.js

View Options

native/identity-service/identity-service-context-provider.react.js

[lib][native] Keep keyserver in device list after primary logoutClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47579

lib/actions/user-actions.js

lib/shared/device-list-utils.js

lib/types/identity-service-types.js

native/identity-service/identity-service-context-provider.react.js

[lib][native] Keep keyserver in device list after primary logout
ClosedPublic
Actions

Revision Contents
Changeset List