native/database/store.js
66	This file is copy-pasted, the only change is this line. Previously, we had a bug because of passing `communities` - I have no idea why Flow failed to catch it
web/redux/initial-state-gate.js
73	As you can see in `store.js`, on web this was hardcoded to `null`

kamil added a child revision: D14528: [lib][native] introduce `fullBackupSupport` flag.Thu, Apr 3, 4:02 AM

bartek accepted this revision.Thu, Apr 3, 4:42 AM

This revision is now accepted and ready to land.Thu, Apr 3, 4:42 AM

rebase

Harbormaster completed remote builds in B33920: Diff 47685.Mon, Apr 7, 3:57 AM

Closed by commit rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI (authored by kamil). · Explain WhyMon, Apr 7, 4:09 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

3 lines

utils/

__mocks__/

config.js

1 line

native/

data/

sqlite-data-handler.js

74 lines

database/

sqlite-api.js

2 lines

store.js

76 lines

web/

database/

sqlite-api.js

3 lines

	database/
	shared-worker/	utils/

store.js

10 lines

redux/

initial-state-gate.js

6 lines

shared-worker/

utils/

store.js

Diff 47630

View Options

lib/types/sqlite-types.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

lib/utils/mocks/config.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

native/data/sqlite-data-handler.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

View Options

native/database/sqlite-api.js

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines	export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo		\| RawLegacyUpdateRelationshipMessageInfo
\| UpdateRelationshipMessageData		\| UpdateRelationshipMessageData
\| RawUpdateRelationshipMessageInfo,		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
		if (
		data.type === messageTypes.UPDATE_RELATIONSHIP &&
		tomekUnsubmitted Not Done Inline Actions Do we have to check this condition? tomek: Do we have to check this condition?
		atulAuthorUnsubmitted Done Inline Actions Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for both `LEGACY_UPDATE_RELATIONSHIP` and `UPDATE_RELATIONSHIP` messages. atul: Yeah, the reason we need to check this is because `updateRelationshipMessageSpec` is used for…
		atulAuthorUnsubmitted Done Inline Actions JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a sufficient check since that implicitly tells us that the message type is `UPDATE_RELATIONSHIP` so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise atul: JK, I think what you're saying is that `data.operation === 'farcaster_mutual'` would be a…
		tomekUnsubmitted Not Done Inline Actions Ok, we can keep both conditions. tomek: Ok, we can keep both conditions.
		data.operation === 'farcaster_mutual'
		) {
		return JSON.stringify({
		operation: data.operation,
		targetID: data.targetID,
		creatorFID: data.creatorFID,
		targetFID: data.targetFID,
		});
		}
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
data:		data:
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines