Paths

Table of Contentst

Differential D14525

[lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI
ClosedPublic
Actions

Authored by kamil on Apr 3 2025, 10:36 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI

Summary

We're now able to call it from /lib and we have a consistent approach.

Depends on D14524

Test Plan

Close and open web/native app to make sure it still works

Diff Detail

Repository

Branch

backup-publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 3 2025, 10:36 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2025, 10:36 AM

kamil edited the summary of this revision. (Show Details)Apr 3 2025, 10:38 AM

Harbormaster completed remote builds in B33880: Diff 47630.Apr 3 2025, 10:53 AM

kamil published this revision for review.Apr 3 2025, 10:53 AM

kamil added inline comments.

native/database/store.js
66	This file is copy-pasted, the only change is this line. Previously, we had a bug because of passing `communities` - I have no idea why Flow failed to catch it
web/redux/initial-state-gate.js
73	As you can see in `store.js`, on web this was hardcoded to `null`

kamil added a child revision: D14528: [lib][native] introduce `fullBackupSupport` flag.Apr 3 2025, 11:02 AM

bartek accepted this revision.Apr 3 2025, 11:42 AM

This revision is now accepted and ready to land.Apr 3 2025, 11:42 AM

rebase

Harbormaster completed remote builds in B33920: Diff 47685.Apr 7 2025, 10:57 AM

Closed by commit rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI. · Explain WhyApr 7 2025, 11:09 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa373e93f8f0b: [lib][web][native] refactor `getClientDBStore` to be part of SQLiteAPI.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

3 lines

utils/

__mocks__/

1 line

native/

data/

sqlite-data-handler.js

74 lines

database/

2 lines

76 lines

web/

database/

3 lines

	database/
	shared-worker/	utils/

10 lines

redux/

initial-state-gate.js

6 lines

shared-worker/

utils/

Diff 47630

lib/types/sqlite-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/data/sqlite-data-handler.js

Loading...

native/database/sqlite-api.js

Loading...

native/database/store.js

Loading...

web/database/sqlite-api.js

Loading...

web/database/store.js

Loading...

web/redux/initial-state-gate.js

Loading...

web/shared-worker/utils/store.js

Loading...