Page MenuHomePhorge
Feed Search

Dec 13 2022

kamil updated the summary of D5831: [native] Terms of Use & Privacy modal.
Dec 13 2022, 5:08 PM
kamil added inline comments to D5832: [native] policy acknowledgment handler.
Dec 13 2022, 5:05 PM
kamil updated the diff for D5832: [native] policy acknowledgment handler.

move handler into NavigationHandler

Dec 13 2022, 5:05 PM
kamil updated the diff for D5831: [native] Terms of Use & Privacy modal.

improve styling, disable back button on andriod, improve code

Dec 13 2022, 5:02 PM
kamil added inline comments to D5845: [native] fix assumption that in `ThreadScreenPruner` app route is defined.
Dec 13 2022, 4:30 PM
kamil updated the diff for D5845: [native] fix assumption that in `ThreadScreenPruner` app route is defined.

rebase

Dec 13 2022, 4:29 PM
kamil published D5860: [web] refactor modal API to return modal key for review.
Dec 13 2022, 4:22 PM
kamil updated the summary of D5829: [web] Terms of Use & Privacy modal.
Dec 13 2022, 4:21 PM
kamil added inline comments to D5830: [web] policy acknowledgment handler.
Dec 13 2022, 4:17 PM
kamil updated the diff for D5830: [web] policy acknowledgment handler.

use ModalContext as information wether modal is visible, improve code

Dec 13 2022, 4:14 PM
kamil updated the diff for D5829: [web] Terms of Use & Privacy modal.

improve code, fix modal jumping

Dec 13 2022, 3:07 PM
kamil added a comment to D5828: [lib] client function to call server and acknowledge policy.

It's hard to review something when you just introduce a function without introducing its usage

Dec 13 2022, 1:58 PM
kamil updated the diff for D5828: [lib] client function to call server and acknowledge policy.

remove startingPayload

Dec 13 2022, 1:52 PM
kamil updated the diff for D5827: [lib] handle `policies_not_accepted` error on client.

fix identation, make optional parameter last in function signature

Dec 13 2022, 1:49 PM
kamil added inline comments to D5826: [lib] client side logic for handling policy acknowledgment.
Dec 13 2022, 1:45 PM
kamil updated the diff for D5826: [lib] client side logic for handling policy acknowledgment.

merge imports, make fields read-only

Dec 13 2022, 1:43 PM
kamil added inline comments to D5824: [keyserver] validate if policies are acknowledged on request.
Dec 13 2022, 1:34 PM
kamil updated the diff for D5824: [keyserver] validate if policies are acknowledged on request.

add early exit, use filter()

Dec 13 2022, 1:32 PM
kamil added inline comments to D5823: [keyserver] refactor JSON endpoints to require policy acknowledgment.
Dec 13 2022, 1:26 PM
kamil updated the diff for D5823: [keyserver] refactor JSON endpoints to require policy acknowledgment.

instroduce constant with common policies

Dec 13 2022, 1:21 PM
kamil added inline comments to D5822: [keyserver] add viewer acknowledgment fetcher.
Dec 13 2022, 12:50 PM
kamil updated the diff for D5822: [keyserver] add viewer acknowledgment fetcher.

improve query, make types read-only

Dec 13 2022, 12:45 PM
kamil added inline comments to D5821: [keyserver] add endpoint to acknowledge policy.
Dec 13 2022, 12:43 PM
kamil updated the diff for D5821: [keyserver] add endpoint to acknowledge policy.

make policy_acknowledgment session changing endpoint

Dec 13 2022, 12:41 PM

Dec 12 2022

kamil closed D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source".
Dec 12 2022, 12:17 PM
kamil added a reverting change for D5312: [keyserver] update acknowledgment table in login was performed from proper source: rCOMM9bb6b3a0a864: Revert "[keyserver] update acknowledgment table in login was performed from….
Dec 12 2022, 12:17 PM
kamil added a reverting change for rCOMM9abc808939ae: [keyserver] update acknowledgment table in login was performed from proper…: rCOMM9bb6b3a0a864: Revert "[keyserver] update acknowledgment table in login was performed from….
Dec 12 2022, 12:17 PM
kamil committed rCOMM9bb6b3a0a864: Revert "[keyserver] update acknowledgment table in login was performed from….
Dec 12 2022, 12:17 PM
kamil planned changes to D5832: [native] policy acknowledgment handler.
Dec 12 2022, 10:30 AM

Dec 9 2022

kamil added a reviewer for D5844: [native] Add hamburger menu button for opening community drawer: tomek.

I would love to review this diff but I wasn't following the previous diffs connected to CommunityDrawer, I feel like my feedback will not be valuable so I am adding @tomek as a blocking reviewer, adding only some nits inline.

Dec 9 2022, 3:31 PM
kamil requested review of D5832: [native] policy acknowledgment handler.
Dec 9 2022, 12:13 PM

Dec 8 2022

kamil published D5832: [native] policy acknowledgment handler for review.
Dec 8 2022, 2:55 PM
kamil published D5831: [native] Terms of Use & Privacy modal for review.
Dec 8 2022, 2:55 PM
kamil published D5845: [native] fix assumption that in `ThreadScreenPruner` app route is defined for review.
Dec 8 2022, 2:48 PM
kamil updated the summary of D5826: [lib] client side logic for handling policy acknowledgment.
Dec 8 2022, 9:46 AM

Dec 6 2022

kamil published D5830: [web] policy acknowledgment handler for review.
Dec 6 2022, 4:10 PM
kamil published D5829: [web] Terms of Use & Privacy modal for review.
Dec 6 2022, 4:09 PM
kamil published D5828: [lib] client function to call server and acknowledge policy for review.
Dec 6 2022, 2:56 PM
kamil published D5827: [lib] handle `policies_not_accepted` error on client for review.
Dec 6 2022, 2:56 PM
kamil published D5826: [lib] client side logic for handling policy acknowledgment for review.
Dec 6 2022, 2:55 PM
kamil published D5824: [keyserver] validate if policies are acknowledged on request for review.
Dec 6 2022, 2:55 PM
kamil published D5823: [keyserver] refactor JSON endpoints to require policy acknowledgment for review.
Dec 6 2022, 2:55 PM
kamil published D5822: [keyserver] add viewer acknowledgment fetcher for review.
Dec 6 2022, 2:55 PM
kamil published D5821: [keyserver] add endpoint to acknowledge policy for review.
Dec 6 2022, 2:55 PM
kamil published D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source" for review.
Dec 6 2022, 2:55 PM
kamil added a reverting change for rCOMM9abc808939ae: [keyserver] update acknowledgment table in login was performed from proper…: D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source".
Dec 6 2022, 1:39 PM
kamil added a reverting change for D5312: [keyserver] update acknowledgment table in login was performed from proper source: D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source".
Dec 6 2022, 1:39 PM

Nov 22 2022

kamil closed D5310: [keyserver] add script to force users to acknowledge updated policy.
Nov 22 2022, 2:33 PM
kamil committed rCOMMdee41ab61dcd: [keyserver] add script to force users to acknowledge updated policy.
Nov 22 2022, 2:33 PM
kamil closed D5664: [keyserver] add entry in acknowledgment table on user sign up.
Nov 22 2022, 2:33 PM
kamil committed rCOMMc78c1fe5131d: [keyserver] add entry in acknowledgment table on user sign up.
Nov 22 2022, 2:33 PM
kamil closed D5312: [keyserver] update acknowledgment table in login was performed from proper source.
Nov 22 2022, 2:33 PM
kamil committed rCOMM9abc808939ae: [keyserver] update acknowledgment table in login was performed from proper….
Nov 22 2022, 2:33 PM
kamil closed D5311: [keyserver] add logic to update acknowledgment table.
Nov 22 2022, 2:33 PM
kamil committed rCOMM328b5c5d0af4: [keyserver] add logic to update acknowledgment table.
Nov 22 2022, 2:33 PM
kamil closed D5663: [keyserver] add migration to populate `policy_acknowledgments` table.
Nov 22 2022, 2:33 PM
kamil committed rCOMMb987bdc86942: [keyserver] add migration to populate `policy_acknowledgments` table.
Nov 22 2022, 2:33 PM
kamil closed D5308: [keyserver] add code to create `policy_acknowledgments` table on database setup.
Nov 22 2022, 2:33 PM
kamil committed rCOMMea01f20da72d: [keyserver] add code to create `policy_acknowledgments` table on database setup.
Nov 22 2022, 2:33 PM
kamil closed D5307: [keyserver] add migration to create `policy_acknowledgments` table.
Nov 22 2022, 2:33 PM
kamil committed rCOMM14e7077b61e5: [keyserver] add migration to create `policy_acknowledgments` table.
Nov 22 2022, 2:33 PM
kamil closed D5306: [lib] add legal policies list.
Nov 22 2022, 2:33 PM
kamil committed rCOMM06f3ea0cc42a: [lib] add legal policies list.
Nov 22 2022, 2:33 PM
kamil updated the diff for D5664: [keyserver] add entry in acknowledgment table on user sign up.

fix - remove old call

Nov 22 2022, 2:15 PM
kamil updated the diff for D5664: [keyserver] add entry in acknowledgment table on user sign up.

combine promise

Nov 22 2022, 2:13 PM
kamil updated the diff for D5312: [keyserver] update acknowledgment table in login was performed from proper source.

combine promise

Nov 22 2022, 2:10 PM
kamil updated the diff for D5310: [keyserver] add script to force users to acknowledge updated policy.

rebase

Nov 22 2022, 1:08 PM
kamil updated the diff for D5664: [keyserver] add entry in acknowledgment table on user sign up.

update function name, rebase

Nov 22 2022, 1:06 PM
kamil updated the diff for D5312: [keyserver] update acknowledgment table in login was performed from proper source.

update function name, rebase

Nov 22 2022, 1:00 PM
kamil updated the diff for D5311: [keyserver] add logic to update acknowledgment table.

rebase, rename function

Nov 22 2022, 12:56 PM
kamil updated the diff for D5663: [keyserver] add migration to populate `policy_acknowledgments` table.

rebase, update migration index

Nov 22 2022, 12:53 PM
kamil updated the diff for D5308: [keyserver] add code to create `policy_acknowledgments` table on database setup.

rebase

Nov 22 2022, 12:51 PM
kamil updated the diff for D5307: [keyserver] add migration to create `policy_acknowledgments` table.

rebase, update migration number

Nov 22 2022, 12:45 PM
kamil updated the diff for D5306: [lib] add legal policies list.

rebase

Nov 22 2022, 12:42 PM
kamil updated the diff for D5310: [keyserver] add script to force users to acknowledge updated policy.

rebase before landing

Nov 22 2022, 12:41 PM
kamil requested review of D5312: [keyserver] update acknowledgment table in login was performed from proper source.
Nov 22 2022, 11:31 AM

Nov 21 2022

kamil closed D5695: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file.
Nov 21 2022, 1:00 PM
kamil committed rCOMM66f1d74860ca: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file.
Nov 21 2022, 1:00 PM
kamil accepted D5672: [native] Don't call dispatch from reducer.

This sounds okay to me. I've created a task ENG-2312 (which is a subtask of ENG 1974) to make sure that this case will be covered.

Nov 21 2022, 12:54 PM
kamil published D5695: [native] remove additional `TerminateApp.mm` entry in `pbxproj` file for review.
Nov 21 2022, 12:24 PM
kamil closed D5594: [native] introduce error handling to cover cancelled database tasks.
Nov 21 2022, 11:42 AM
kamil closed D5579: [native] refactor CommCoreModule to allow cancellable tasks.
Nov 21 2022, 11:42 AM
kamil committed rCOMM6c35669e5805: [native] introduce error handling to cover cancelled database tasks.
Nov 21 2022, 11:42 AM
kamil committed rCOMM615b98191857: [native] refactor CommCoreModule to allow cancellable tasks.
Nov 21 2022, 11:42 AM
kamil closed D5578: [native] implement method to run asynchronous cancellable task in CommCoreModule and return error via promise.
Nov 21 2022, 11:42 AM
kamil closed D5577: [native] implement method to run synchronous cancellable task in CommCoreModule.
Nov 21 2022, 11:42 AM
kamil committed rCOMM4cb87f3b1daf: [native] implement method to run asynchronous cancellable task in….
Nov 21 2022, 11:42 AM
kamil committed rCOMMafc218bf615f: [native] implement method to run synchronous cancellable task in CommCoreModule.
Nov 21 2022, 11:42 AM
kamil closed D5576: [native] introduce atomic flag that indicates clearing database process will execute.
Nov 21 2022, 11:42 AM
kamil committed rCOMMcbc10b676b1f: [native] introduce atomic flag that indicates clearing database process will….
Nov 21 2022, 11:42 AM
kamil updated the diff for D5594: [native] introduce error handling to cover cancelled database tasks.

rebase before landing

Nov 21 2022, 10:07 AM
kamil updated the diff for D5579: [native] refactor CommCoreModule to allow cancellable tasks.

rebase before landing

Nov 21 2022, 10:06 AM
kamil updated the diff for D5578: [native] implement method to run asynchronous cancellable task in CommCoreModule and return error via promise.

rebase before landing, use explicit capture

Nov 21 2022, 10:05 AM
kamil updated the diff for D5577: [native] implement method to run synchronous cancellable task in CommCoreModule.

rebase before landing

Nov 21 2022, 10:05 AM
kamil updated the diff for D5576: [native] introduce atomic flag that indicates clearing database process will execute.

rebase before landing

Nov 21 2022, 10:04 AM

Nov 18 2022

kamil closed D5618: [native] c++ interface to kill app on iOS and Android.
Nov 18 2022, 10:26 AM
kamil committed rCOMM2007dbe05b7d: [native] c++ interface to kill app on iOS and Android.
Nov 18 2022, 10:26 AM
kamil updated the diff for D5618: [native] c++ interface to kill app on iOS and Android.

rebase before landing, remove additional line

Nov 18 2022, 10:12 AM

Nov 17 2022

kamil added inline comments to D5310: [keyserver] add script to force users to acknowledge updated policy.
Nov 17 2022, 11:27 AM
kamil updated the diff for D5310: [keyserver] add script to force users to acknowledge updated policy.

rebase

Nov 17 2022, 11:25 AM