Rebasing on parent changes.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 15 2023
Feb 15 2023
• max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
• max committed rCOMMca943860dfbf: [tunnelbroker-client] Adding `publish_message` client function (authored by • max).
[tunnelbroker-client] Adding `publish_message` client function
Rebasing on master changes.
• max committed rCOMM48ba3b6f41fa: [buildkite] Adding CI test for the Tunnelbroker client shared library (authored by • max).
[buildkite] Adding CI test for the Tunnelbroker client shared library
• max committed rCOMM198b5282a027: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function (authored by • max).
[tunnelbroker-client] Adding Tunnelbroker tonic client initialization function
• max updated the diff for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Fixing to typo in a comment.
• max added a comment to D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
In D6281#200724, @varun wrote:Typo in “to” just FYI
• max updated the diff for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Rebasing on parent changes.
Feb 13 2023
Feb 13 2023
• max published D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish` for review.
Feb 10 2023
Feb 10 2023
• max added inline comments to D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.
Feb 9 2023
Feb 9 2023
• max added inline comments to D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.
• max updated the diff for D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.
Fixing space.
Feb 8 2023
Feb 8 2023
Feb 6 2023
Feb 6 2023
• max published D6626: [services] Tunnelbroker - Disabling messages persistence on messages removing for review.
• max published D6624: [services] Tunnelbroker - Disabling messages persistence on messages send for review.
• max published D6622: [services] Tunnelbroker - Disable messages persistence config parameter for review.
• max updated the summary of D6490: [services] Tunnelbroker - Add disable notifications config parameter.
• max updated the summary of D6490: [services] Tunnelbroker - Add disable notifications config parameter.
Feb 4 2023
Feb 4 2023
• max updated subscribers of D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#196300, @bartek wrote:Resigning not to block you while I'm off. Glad to hear it's working without unsafe!
Feb 3 2023
Feb 3 2023
• max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#195963, @varun wrote:I tried building your changes locally but I got the following error: error: &mut self is incompatible with async napi methods
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Removing mut and unsafe.
Feb 2 2023
Feb 2 2023
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Rebasing on parent changes.
• max added inline comments to D6284: [tunnelbroker-client] Adding `publish_message` client function.
Fix function name to plural.
• max requested review of D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
• max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#195513, @varun wrote:I see an async class method in the docs: https://napi.rs/docs/concepts/class#class-method
Are we sure we need unsafe here?
• max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Fixing comment.
• max added a comment to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
In D6283#194441, @ashoat wrote:Let's make sure we don't land this until we have clarity on the Windows GitHub issue, or at least we should be ready to revert it immediately if it breaks that
• max published D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function for review.
• max added inline comments to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Updating on parent D6284 changes.
• max added inline comments to D6459: [keyserver] Adding Tunnelbroker-client napi-rs class constructor.
Addressing comments:
- Changes to use tunnelbroker service address from the environment variable.
• max added inline comments to D6284: [tunnelbroker-client] Adding `publish_message` client function.
Addressing comments.
• max updated the diff for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Changing protobuf codegen name from protobuff to tunnelbroker_pb based on the D6284#inline-43306 comment
Feb 1 2023
Feb 1 2023
• max committed rCOMM3e22505179f4: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf (authored by • max).
[tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf
• max updated the diff for D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.
Adding an empty src/lib.rs to pass the updated rs linter. src/lib.rs will be populated in the next D6281 diff.
• max updated the diff for D6279: [tunnelbroker-client] Adding of the `build.rs` cargo file to compile protobuf.
Rebasing on master changes.
• max committed rCOMM121a4d546a1a: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the… (authored by • max).
[tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the…
• max updated the diff for D6278: [tunnelbroker-client] Adding `shared/tunnelbroker-client` target folder to the `.gitignore`.
Rebasing.
• max committed rCOMM127dbcc6f0ea: [tunnelbroker-client] Creating a Cargo project file (authored by • max).
[tunnelbroker-client] Creating a Cargo project file
Rebasing on the master.
• max committed rCOMMdc0769825150: [services] Tunnelbroker - Skipping session checks in a stream when… (authored by • max).
[services] Tunnelbroker - Skipping session checks in a stream when…
In D6277#194283, @bartek wrote:once_cell is an alternative to lazy_static that has a few advantages:
- Doesn't need to use a macro
- is actively maintained (lazy static latest release is from 3 years ago)
- there's an RFC to include it in Rust standard library
- has a few more handy features (docs link)
• max updated the diff for D6253: [services] Tunnelbroker - Skipping session checks in a stream when `skip_authentication` flag is set.
Rebasing on the parent changes.
• max committed rCOMMf8a59aa046e2: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust (authored by • max).
[services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust
• max updated the diff for D6252: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust.
Rebasing on master.
• max updated the diff for D6252: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust.
Rebasing on parent changes.
• max committed rCOMMeee4ca130b65: [services] Tunnelbroker - Add skip authentication config parameter (authored by • max).
[services] Tunnelbroker - Add skip authentication config parameter
• max published D6490: [services] Tunnelbroker - Add disable notifications config parameter for review.
Jan 31 2023
Jan 31 2023
• max planned changes to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Rebasing.
In D6459#193751, @ashoat wrote:Can you rebase your diffs on that one to address the CI failures?
Rebasing.
• max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#193421, @ashoat wrote:Any idea why the CI failures are occurring then?
In D6459#193420, @ashoat wrote:Any idea why the CI failures are occurring then?
Jan 30 2023
Jan 30 2023
• max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Please ignore ESLint fails, for now, because the failure seems doesn't relate to the keyserver (it's successfully built).
Please ignore Codegen and ESLint fails, for now, because the failure seems doesn't relate to the keyserver (it's successfully built).
• max published D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method for review.
• max updated the diff for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Removing of unused template.
• max added inline comments to D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
• max updated the diff for D6281: [tunnelbroker-client] Adding Tunnelbroker tonic client initialization function.
Changing imported protobuff codegen name from tunnelbroker to the protobuff and making it public.
Fixing expect error message.
Jan 27 2023
Jan 27 2023
Updating tokio version and license.
Jan 26 2023
Jan 26 2023
• max added inline comments to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
• max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Rebasing on parent changes.
• max added a comment to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Updating ENG-2808 on the protoc build issue.
• max added inline comments to D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
• max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Adding cmake to dependencies.
Jan 25 2023
Jan 25 2023
• max updated the diff for D6283: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies.
Adding scripts to copy.