In D6898#205080, @ashoat wrote:Please make the requested edit before landing. Otherwise Flow types look good, but defer to others on Rust
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 1 2023
Mar 1 2023
• max added a comment to D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming.
• max updated the diff for D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming.
Addressing comment.
Feb 27 2023
Feb 27 2023
• max added a reviewer for D6898: [keyserver] Tunnelbroker integration - Adding message object on message consuming: bartek.
• max committed rCOMM35260f3a78a9: [keyserver] Unifying API interface and adding Tunnelbroker types (authored by • max).
[keyserver] Unifying API interface and adding Tunnelbroker types
• max committed rCOMM70ebd47b4563: [services] Tunnelbroker - Fix calling blocking C++ function from an async task (authored by • max).
[services] Tunnelbroker - Fix calling blocking C++ function from an async task
Rebasing on master and parent changes.
In D6690#203834, @ashoat wrote:Fix Flow types and remove .default
• max committed rCOMM31a3e54aa020: [keyserver] Adding metadata to the Tunnelbroker client constructor (authored by • max).
[keyserver] Adding metadata to the Tunnelbroker client constructor
• max updated the diff for D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.
Fixing commit and rebasing on master.
Feb 26 2023
Feb 26 2023
• max added inline comments to D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task.
Feb 23 2023
Feb 23 2023
Adding @jon to take a look.
• max edited reviewers for D6690: [keyserver] Unifying API interface and adding Tunnelbroker types, added: • jon; removed: ginsu.
• max updated subscribers of D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Rebasing on master changes.
Abandoning this revision in a favor of D6690.
• max committed rCOMM266b7425934b: [services] Tunnelbroker - Skipping sending notif token request when… (authored by • max).
[services] Tunnelbroker - Skipping sending notif token request when…
• max updated the diff for D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor.
Rebasing on master to fix build.
In D6771#202707, @varun wrote:what is device ID in the context of tunnelbroker? just curious because we're replacing the concept of a device ID with a device public key in the Identity service
• max committed rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter (authored by • max).
[services] Tunnelbroker - Add disable notifications config parameter
• max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.
Rebasing on master and parent changes.
• max updated the diff for D6490: [services] Tunnelbroker - Add disable notifications config parameter.
Rebasing on master, parent changes and D6749 fix.
• max committed rCOMM7fa036f59002: [services] Tunnelbroker - Disabling messages persistence on messages removing (authored by • max).
[services] Tunnelbroker - Disabling messages persistence on messages removing
• max committed rCOMMc7c87fa04cab: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate… (authored by • max).
[services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate…
• max committed rCOMMf95747ecac53: [services] Tunnelbroker - Disabling messages persistence on messages send (authored by • max).
[services] Tunnelbroker - Disabling messages persistence on messages send
• max updated the diff for D6626: [services] Tunnelbroker - Disabling messages persistence on messages removing.
Rebasing on master and parent changes.
• max updated the diff for D6625: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function.
Rebasing on master and parent changes.
• max committed rCOMM343be0ba9181: [services] Tunnelbroker - Disabling checking of the persisted messages on… (authored by • max).
[services] Tunnelbroker - Disabling checking of the persisted messages on…
• max committed rCOMM43468c1caea8: [services] Tunnelbroker - Disable messages persistence config parameter (authored by • max).
[services] Tunnelbroker - Disable messages persistence config parameter
• max updated the diff for D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.
Rebasing on master and parent changes.
• max updated the diff for D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.
Rebasing on master.
• max added inline comments to D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.
• max updated the diff for D6622: [services] Tunnelbroker - Disable messages persistence config parameter.
Rebasing on master, fixing based on D6749 changes.
• max published D6843: [services] Tunnelbroker - Fix calling blocking C++ function from an async task for review.
Feb 21 2023
Feb 21 2023
• max committed rCOMMe0bc3f7ac53c: [services] Tunnelbroker - Disabling updating session state when session… (authored by • max).
[services] Tunnelbroker - Disabling updating session state when session…
• max committed rCOMMd21e55e6c13a: [keyserver] Adding Tunnelbroker-client napi-rs publish class method (authored by • max).
[keyserver] Adding Tunnelbroker-client napi-rs publish class method
• max committed rCOMM430209fa1517: [keyserver] Adding Tunnelbroker-client napi-rs class constructor (authored by • max).
[keyserver] Adding Tunnelbroker-client napi-rs class constructor
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Rebasing on master.
Rebasing on master.
• max committed rCOMM28b3c262873e: [services] Tunnelbroker - Adding boolean config parameters to be used in the… (authored by • max).
[services] Tunnelbroker - Adding boolean config parameters to be used in the…
• max committed rCOMMf1bc99677895: [keyserver] Removing `.gitignore` from rust-node-addon (authored by • max).
[keyserver] Removing `.gitignore` from rust-node-addon
• max retitled D6792: [keyserver] Removing `.gitignore` from rust-node-addon from [keyserver] Removing `.gitignore` in rust-node-addon to [keyserver] Removing `.gitignore` from rust-node-addon.
Reopening this diff due to solving ENG-3048.
Reopening this diff due to solving ENG-3048.
In D6792#202240, @varun wrote:i actually prefer having separate .gitignore files at the cargo project level but it’s not a strong opinion. just think it makes the files more readable. also we already have other .gitignore files in the repo I think
• max committed rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it (authored by • max).
[keyserver] Removing from the rust-node-addon gitignore and populate it
Feb 20 2023
Feb 20 2023
• max published D6791: [keyserver] Removing from the rust-node-addon gitignore and populate it for review.
• max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.
Fixing parent stack.
• max added inline comments to D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.
• max updated the diff for D6688: [keyserver] Refactoring `redisPublish` function to `messageBrokerPublish`.
Renaming promises.redis to promises.messageBroker.
• max retitled D6690: [keyserver] Unifying API interface and adding Tunnelbroker types from [keyserver] Adding of Tunnelbroker client type interface and getter in `rust-node-addon` index file to [keyserver] Unifying API interface and adding Tunnelbroker types.
Fixing type file import path.
• max updated the summary of D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.
Refactoring function to be used in any provided API, refactoring types, moving types to a separate file.
• max published D6771: [keyserver] Adding metadata to the Tunnelbroker client constructor for review.
Feb 16 2023
Feb 16 2023
Feb 15 2023
Feb 15 2023
• max committed rCOMM044b8239d2c4: [services] Tunnelbroker - Skipping `deviceID` validation in tools function (authored by • max).
[services] Tunnelbroker - Skipping `deviceID` validation in tools function
• max added inline comments to D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.
• max updated the diff for D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.
Removing logging.
• max committed rCOMM5a05f25ddd00: [services] Tunnelbroker - Add disable `deviceID` format validation config… (authored by • max).
[services] Tunnelbroker - Add disable `deviceID` format validation config…
• max committed rCOMM7b4e9f3176d2: [keyserver] Adding Tunnelbroker-client napi-rs publish class method (authored by • max).
[keyserver] Adding Tunnelbroker-client napi-rs publish class method
• max added a comment to D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
In D6460#197482, @varun wrote:awesome! nice job max
would you mind explaining how you avoided the mut requirement?
• max updated the diff for D6460: [keyserver] Adding Tunnelbroker-client napi-rs publish class method.
Rebasing on parent.
• max committed rCOMMa1400b0cb428: [keyserver] Adding Tunnelbroker-client napi-rs class constructor (authored by • max).
[keyserver] Adding Tunnelbroker-client napi-rs class constructor
Rebasing on parent changes.
• max committed rCOMMccb92e0486e1: [keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies (authored by • max).
[keyserver] Adding `tunnelbroker-client` to the keyserver napi-rs dependencies