Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Mar 7 2023

• kuba requested review of D6962: [lib][keyserver] Add editing message type to messageTypes.

Mar 7 2023, 1:49 AM

• kuba requested review of D6961: [lib] Create types for message editing.

Mar 7 2023, 1:47 AM

Feb 28 2023

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Fixing wrong rebasing

Feb 28 2023, 3:25 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Another try to fix rebasing

Feb 28 2023, 3:23 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Feb 28 2023, 3:22 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Feb 28 2023, 3:17 AM

Feb 27 2023

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Undo rebase

Feb 27 2023, 4:49 AM

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase

Feb 27 2023, 4:33 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Feb 27 2023, 4:32 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Feb 27 2023, 4:32 AM

• kuba updated the diff for D5462: [keyserver] Update userStore from chat creation url.

Rebase

Feb 27 2023, 4:32 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 27 2023, 4:29 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Fixed according to Michal notes

Feb 27 2023, 4:28 AM

Feb 24 2023

• kuba removed reviewers for D5463: [web] Call searchUsers in chat composer: atul, • abosh.

Feb 24 2023, 4:07 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Used function from the lib instead of rewriting it

Feb 24 2023, 4:06 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 24 2023, 3:56 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase - parent update

Feb 24 2023, 3:46 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Removed deepclone, surrounded dispatch with if in case of empty payload

Feb 24 2023, 3:40 AM

Feb 23 2023

• kuba updated the test plan for D6846: [native] Deleted react-native-exit-app library.

Feb 23 2023, 6:01 AM

• kuba requested review of D6846: [native] Deleted react-native-exit-app library.

Feb 23 2023, 5:38 AM

• kuba requested review of D6844: [native] Replaced react-native-exit-app calls with CommCoreModule calls.

Feb 23 2023, 4:11 AM

• kuba retitled D6834: [native] Added terminate() implementation in JS and CommCoreModule from [native] Removed `react-native-exit-app` library to [native] Added terminate() implementation in JS and CommCoreModule.

Feb 23 2023, 3:50 AM

• kuba updated the diff for D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Removed added unintentionally "TODO"

Feb 23 2023, 3:46 AM

• kuba updated the diff for D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Splitting into 3 diffs

Feb 23 2023, 3:43 AM

• kuba added a comment to D6834: [native] Added terminate() implementation in JS and CommCoreModule.

In D6834#203216, @ashoat wrote:

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

Feb 23 2023, 2:11 AM

• kuba planned changes to D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Feb 23 2023, 2:10 AM

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Lint error after rebase

Feb 23 2023, 1:53 AM

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase again

Feb 23 2023, 1:43 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Updated parent - rebase

Feb 23 2023, 1:31 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 23 2023, 1:24 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Eslint fix

Feb 23 2023, 1:24 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 23 2023, 1:14 AM

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase v3

Feb 23 2023, 1:12 AM

• kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase v3

Feb 23 2023, 1:12 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase v3

Feb 23 2023, 1:11 AM

• kuba updated the diff for D5462: [keyserver] Update userStore from chat creation url.

Rebase v3

Feb 23 2023, 1:10 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 23 2023, 1:03 AM

• kuba updated the diff for D5462: [keyserver] Update userStore from chat creation url.

Rebase

Feb 23 2023, 12:38 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Lint errors

Feb 23 2023, 12:34 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 23 2023, 12:13 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase v2

Feb 23 2023, 12:12 AM

Feb 22 2023

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebasing v2

Feb 22 2023, 7:12 AM

• kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase

Feb 22 2023, 6:07 AM

• kuba commandeered D5462: [keyserver] Update userStore from chat creation url.

Feb 22 2023, 6:06 AM

• kuba commandeered D5583: [web] Change alert type in UserListItem.

Feb 22 2023, 6:06 AM

• kuba commandeered D5518: [web] Unify behaviour of chat composer with native.

Feb 22 2023, 6:06 AM

• kuba planned changes to D5463: [web] Call searchUsers in chat composer.

Feb 22 2023, 3:21 AM

• kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase to master

Feb 22 2023, 3:19 AM

• kuba requested review of D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Feb 22 2023, 3:17 AM

• kuba commandeered D5463: [web] Call searchUsers in chat composer.

Feb 22 2023, 3:04 AM

Feb 21 2023

• kuba updated the diff for D6743: [native] Fixed 'items not removed from ChatList [..]' error.

Rebase

Feb 21 2023, 5:50 AM

• kuba commandeered D6393: Fixed incorret display for long thread names on web..

Feb 21 2023, 5:23 AM

• kuba updated the diff for D6743: [native] Fixed 'items not removed from ChatList [..]' error.

Changed comment

Feb 21 2023, 5:18 AM

Feb 17 2023

• kuba added a comment to D6744: [keyserver] Block creating new chats with users that you are not friends with.

It was already fixed by @michal in https://phab.comm.dev/D5518. He said he will land the changes when he has time.

Feb 17 2023, 3:16 AM

• kuba requested review of D6743: [native] Fixed 'items not removed from ChatList [..]' error.

Feb 17 2023, 1:27 AM

• kuba added a comment to D6744: [keyserver] Block creating new chats with users that you are not friends with.

In D6744#200943, @inka wrote:

I feel like we should handle this differently. It is entirely unclear to the user what went wrong and how to fix it

Feb 17 2023, 12:31 AM

Feb 16 2023

• kuba added a comment to D6744: [keyserver] Block creating new chats with users that you are not friends with.

In D6744#200943, @inka wrote:

I feel like we should handle this differently. It is entirely unclear to the user what went wrong and how to fix it

Feb 16 2023, 7:23 AM

• kuba attached a referenced file: F383308: IMG_587B1A99FCFA-1.jpeg.

Feb 16 2023, 7:22 AM

• kuba added a comment to D6744: [keyserver] Block creating new chats with users that you are not friends with.

I found other possible problems:

When we use chat composer and try to find a user, with whom we don't have any common chats, it doesn't show up in the list.
If we want to add a user to sub chat (who is in the parent thread != genesis) who is not our friend, we can't do that. The GUI doesn't let us do that.

Feb 16 2023, 7:19 AM

• kuba added a comment to D6744: [keyserver] Block creating new chats with users that you are not friends with.

In D6744#200902, @ashoat wrote:

If we add a Genesis hack here, we should add a task to ENG-55 to revert it.

Feb 16 2023, 7:18 AM

• kuba accepted D6740: [web] Restyle filters button.

We might add a short transition to the hover state. Looks great!

Feb 16 2023, 5:32 AM

• kuba requested review of D6744: [keyserver] Block creating new chats with users that you are not friends with.

Feb 16 2023, 4:07 AM

• kuba updated the diff for D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.

Removed flex: 1 from camera-modal

Feb 16 2023, 3:23 AM

• kuba added inline comments to D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.

Feb 16 2023, 3:11 AM

• kuba updated the diff for D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.

Removed flex: 1 from staging view overlay

Feb 16 2023, 3:09 AM

Feb 15 2023

• kuba attached a referenced file: F381657: Screenshot_20230215-113106.png.

Feb 15 2023, 2:38 AM

• kuba attached a referenced file: F381658: Screenshot_20230215-113116.png.

Feb 15 2023, 2:38 AM

• kuba added inline comments to D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.

Feb 15 2023, 2:38 AM

• kuba requested review of D6739: [lib] Limit maximum chat name to prevent error.

Feb 15 2023, 2:28 AM

Feb 14 2023

• kuba requested review of D6730: [native] Add SafeAreaView to CameraModal, ImageModal and VideoPlaybackModal.

Feb 14 2023, 4:15 AM

• kuba added a comment to D6685: [native] [ENG-2207] Too big notifications when the message is long.

Fixed Tomek's comments.

Feb 14 2023, 3:34 AM

• kuba updated the diff for D6685: [native] [ENG-2207] Too big notifications when the message is long.

Removing nested array

Feb 14 2023, 3:34 AM

Feb 10 2023

• kuba requested review of D6685: [native] [ENG-2207] Too big notifications when the message is long.

Feb 10 2023, 4:15 AM

• kuba updated the test plan for D6669: [native] Fixing wrong leftBorderColor on the quotes.

Feb 10 2023, 12:32 AM

• kuba updated the test plan for D6669: [native] Fixing wrong leftBorderColor on the quotes.

Feb 10 2023, 12:32 AM

• kuba added a comment to D6669: [native] Fixing wrong leftBorderColor on the quotes.

In D6669#198568, @ashoat wrote:

Can we make this look exactly like iOS? Please share screenshots of iOS in the Test Plan. I think a border is still missing

(Feel free to handle this in a separate task if you prefer)

Feb 10 2023, 12:31 AM

Feb 9 2023

• kuba attached a referenced file: F371022: Screenshot 2023-02-09 at 12.11.37.png.

Feb 9 2023, 3:19 AM

• kuba attached a referenced file: F371023: Screenshot 2023-02-09 at 12.12.42.png.

Feb 9 2023, 3:19 AM

• kuba updated the test plan for D6669: [native] Fixing wrong leftBorderColor on the quotes.

Feb 9 2023, 3:14 AM

• kuba updated the test plan for D6665: [native] Fixed crash when logging out while thread opened.

Feb 9 2023, 3:00 AM

• kuba updated the summary of D6665: [native] Fixed crash when logging out while thread opened.

Feb 9 2023, 3:00 AM

• kuba closed D6665: [native] Fixed crash when logging out while thread opened.

Feb 9 2023, 2:58 AM

• kuba committed rCOMM40596931e8c8: [native] Fixed crash when logging out while thread opened (authored by • kuba).

[native] Fixed crash when logging out while thread opened

Feb 9 2023, 2:58 AM

• kuba requested review of D6669: [native] Fixing wrong leftBorderColor on the quotes.

Feb 9 2023, 2:57 AM

Feb 8 2023

• kuba requested review of D6665: [native] Fixed crash when logging out while thread opened.

Feb 8 2023, 6:23 AM