Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Thu, Oct 31

will committed rCOMMd2f70e0fe779: [keyserver] add regex #createathread check (authored by will).
[keyserver] add regex #createathread check
Thu, Oct 31, 12:18 PM
will closed D13701: [keyserver] add signer_uuid and neynar webhook secret.
Thu, Oct 31, 12:18 PM
will committed rCOMM4628129f5d87: [keyserver] add signer_uuid and neynar webhook secret (authored by will).
[keyserver] add signer_uuid and neynar webhook secret
Thu, Oct 31, 12:18 PM
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
Thu, Oct 31, 12:07 PM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

rebase before landing

Thu, Oct 31, 11:58 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase

Thu, Oct 31, 11:48 AM
will added inline comments to D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.
Thu, Oct 31, 11:44 AM
will updated the diff for D13841: [keyserver] add regex #createathread check.

move regex to top level

Thu, Oct 31, 11:37 AM
will added inline comments to D13841: [keyserver] add regex #createathread check.
Thu, Oct 31, 11:29 AM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

use eventChannel from prior diff instead of event.data.channel

Thu, Oct 31, 10:22 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

add channel to deconstruct

Thu, Oct 31, 10:20 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase

Thu, Oct 31, 10:15 AM
will updated the diff for D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.

rebase

Thu, Oct 31, 10:14 AM
will updated the diff for D13841: [keyserver] add regex #createathread check.

word boundry fix

Thu, Oct 31, 10:09 AM
will updated the diff for D13841: [keyserver] add regex #createathread check.

use regex with word boundries

Thu, Oct 31, 9:48 AM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Thu, Oct 31, 9:36 AM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase and add destruction syntax for code clarity

Thu, Oct 31, 9:25 AM
will updated the diff for D13841: [keyserver] add regex #createathread check.

use .includes instead of regex

Thu, Oct 31, 9:16 AM
will planned changes to D13841: [keyserver] add regex #createathread check.

Thinking about this. I think we should likely go with a non-regex solution as this is such a simple check. Going to change in next rebase

Thu, Oct 31, 9:09 AM
will added a comment to D13841: [keyserver] add regex #createathread check.
In D13841#386565, @ashoat wrote:

Do we really need a RegExp if we're just checking if the string contains another string?

Maybe the best argument for RegExp would be if we're trying to match on word boundaries.

Thu, Oct 31, 7:41 AM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

rebase

Thu, Oct 31, 7:19 AM
will published D13841: [keyserver] add regex #createathread check for review.
Thu, Oct 31, 7:17 AM
will updated the summary of D13755: [keyserver] moving getting neynar config to function.
Thu, Oct 31, 7:16 AM
will added inline comments to D13782: [keyserver] create message and sidebar based on cast.
Thu, Oct 31, 6:10 AM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

remove trimText code duplication with sidebar thread name function

Thu, Oct 31, 6:06 AM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

address nit

Thu, Oct 31, 6:00 AM

Wed, Oct 30

will updated the diff for D13783: [keyserver] create invite link based on newly created sidebar.

rebase

Wed, Oct 30, 7:10 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Wed, Oct 30, 7:05 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Wed, Oct 30, 7:02 PM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

feedback

Wed, Oct 30, 7:01 PM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

rebase

Wed, Oct 30, 6:36 PM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Wed, Oct 30, 6:12 PM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

review feedback

Wed, Oct 30, 6:10 PM
will retitled D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin from [keyserver] Run num admin change checks in updateRole only if request is not by an admin to [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.
Wed, Oct 30, 2:18 PM
will added inline comments to D13784: [lib] add post cast to neynar client.
Wed, Oct 30, 1:52 PM
will updated the diff for D13784: [lib] add post cast to neynar client.

fix nit

Wed, Oct 30, 1:52 PM
will requested review of D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.
Wed, Oct 30, 1:47 PM
will added inline comments to D13783: [keyserver] create invite link based on newly created sidebar.
Wed, Oct 30, 1:47 PM
will updated the diff for D13815: [keyserver] check if viewer role is positive for updateThread.

remove as

Wed, Oct 30, 1:46 PM
will added inline comments to D13815: [keyserver] check if viewer role is positive for updateThread.
Wed, Oct 30, 1:45 PM
will updated the diff for D13754: [keyserver] accept webhook cast created events tagging comm.

rebase

Wed, Oct 30, 1:41 PM
will updated the diff for D13756: [keyserver] verify webhook event with webhook secret.

rebase

Wed, Oct 30, 1:40 PM
will requested review of D13833: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole.
Wed, Oct 30, 1:36 PM
will added inline comments to D13756: [keyserver] verify webhook event with webhook secret.
Wed, Oct 30, 1:34 PM
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
Wed, Oct 30, 1:31 PM
will requested review of D13832: [keyserver] do not filter by role in fetchCommunityInfos calls for script viewers.
Wed, Oct 30, 1:28 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Wed, Oct 30, 1:26 PM
will updated the test plan for D13785: [keyserver] reply on farcaster with invite link.
Wed, Oct 30, 1:24 PM
will updated the diff for D13785: [keyserver] reply on farcaster with invite link.

review feedback and changes

Wed, Oct 30, 1:23 PM
will updated the summary of D13782: [keyserver] create message and sidebar based on cast.
Wed, Oct 30, 1:22 PM
will added inline comments to D13782: [keyserver] create message and sidebar based on cast.
Wed, Oct 30, 1:19 PM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

accidentally left a console.log

Wed, Oct 30, 1:18 PM
will updated the diff for D13782: [keyserver] create message and sidebar based on cast.

feedback and rebase

Wed, Oct 30, 1:16 PM
will added inline comments to D13782: [keyserver] create message and sidebar based on cast.
Wed, Oct 30, 1:16 PM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

feedback and rebase

Wed, Oct 30, 1:07 PM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Wed, Oct 30, 1:07 PM
will requested review of D13819: [keyserver] add the addViewerAsGhost option to createThread.
Wed, Oct 30, 11:27 AM
will abandoned D13813: [keyserver] remove commbot after creating community.
Wed, Oct 30, 11:13 AM
will added a comment to D13813: [keyserver] remove commbot after creating community.

Abandoning this diff. We're going with the approach introduced in https://phab.comm.dev/D13819 where commbot is added as a ghost

Wed, Oct 30, 11:13 AM
will updated the summary of D13782: [keyserver] create message and sidebar based on cast.
Wed, Oct 30, 11:12 AM
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
Wed, Oct 30, 11:10 AM
will abandoned D13816: [keyserver] add dontAddViewerAsMember to createThread.

Abandoning with new approach in setting the viewer as a ghost

Wed, Oct 30, 10:12 AM
will added inline comments to D13816: [keyserver] add dontAddViewerAsMember to createThread.
Wed, Oct 30, 7:48 AM
will requested review of D13816: [keyserver] add dontAddViewerAsMember to createThread.
Wed, Oct 30, 12:30 AM
will updated the summary of D13782: [keyserver] create message and sidebar based on cast.
Wed, Oct 30, 12:15 AM

Tue, Oct 29

will requested review of D13815: [keyserver] check if viewer role is positive for updateThread.
Tue, Oct 29, 11:43 PM
will abandoned D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.

Abandoning. We're no longer planning to override permissions

Tue, Oct 29, 11:29 PM
will updated the summary of D13782: [keyserver] create message and sidebar based on cast.
Tue, Oct 29, 11:27 PM
will added inline comments to D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
Tue, Oct 29, 7:43 PM
will added inline comments to D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
Tue, Oct 29, 7:38 PM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Tue, Oct 29, 4:58 PM
will planned changes to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Tue, Oct 29, 4:57 PM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Tue, Oct 29, 4:54 PM
will updated the diff for D13775: [keyserver] add community creation logic to farcaster webhook responder.

rebase and review feedback

Tue, Oct 29, 4:52 PM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Tue, Oct 29, 4:50 PM
will requested review of D13813: [keyserver] remove commbot after creating community.
Tue, Oct 29, 4:50 PM
will requested review of D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
Tue, Oct 29, 4:40 PM
will updated the diff for D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.

review feedback

Tue, Oct 29, 3:02 PM
will published D13811: [keyserver] add function to grab comm userID for given fid if on keyserver for review.
Tue, Oct 29, 2:34 PM
will updated the summary of D13775: [keyserver] add community creation logic to farcaster webhook responder.
Tue, Oct 29, 2:24 PM

Mon, Oct 28

will updated subscribers of D13774: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator.
Mon, Oct 28, 9:07 PM
will added inline comments to D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.
Mon, Oct 28, 3:01 PM
will updated the diff for D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.

review feedback

Mon, Oct 28, 3:00 PM
will updated the diff for D13755: [keyserver] moving getting neynar config to function.

move getNeynarConfig to own file

Mon, Oct 28, 2:06 PM
will added inline comments to D13755: [keyserver] moving getting neynar config to function.
Mon, Oct 28, 2:06 PM
will updated the diff for D13756: [keyserver] verify webhook event with webhook secret.

feedback

Mon, Oct 28, 1:51 PM
will accepted D13797: [landing] Add Farcaster link to header.
Mon, Oct 28, 1:06 PM
will accepted D13798: [landing] Bump GitHub link to the front.
Mon, Oct 28, 1:05 PM
will accepted D13796: [landing] Add Farcaster link to team profiles.
Mon, Oct 28, 12:42 PM

Fri, Oct 25

will accepted D13790: [identity] bump native min supported version and add web min supported version.
Fri, Oct 25, 1:33 PM

Thu, Oct 24

will accepted D13789: [keyserver][landing] Fix reset preamble for landing SIWE.
Thu, Oct 24, 7:56 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Thu, Oct 24, 1:17 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Thu, Oct 24, 9:48 AM
will added inline comments to D13775: [keyserver] add community creation logic to farcaster webhook responder.
Thu, Oct 24, 6:54 AM
will planned changes to D13785: [keyserver] reply on farcaster with invite link.

Planning changes based on Tomek's feedback

Thu, Oct 24, 6:23 AM
will added inline comments to D13783: [keyserver] create invite link based on newly created sidebar.
Thu, Oct 24, 6:18 AM
will added inline comments to D13782: [keyserver] create message and sidebar based on cast.
Thu, Oct 24, 6:18 AM

Wed, Oct 23

will updated the test plan for D13784: [lib] add post cast to neynar client.
Wed, Oct 23, 11:53 PM
will published D13784: [lib] add post cast to neynar client for review.
Wed, Oct 23, 11:52 PM
will added inline comments to D13785: [keyserver] reply on farcaster with invite link.
Wed, Oct 23, 11:52 PM
First
Prev
Next