Page MenuHomePhorge
Feed Search

Jul 30 2025

ashoat added inline comments to D15019: [Flow262][skip-ci] Fix colors.js errors.
Jul 30 2025, 8:31 PM
ashoat requested changes to D15015: [Flow262][skip-ci] Change React.AbstractComponent -> React.ComponentType.

Based on my read of the docs, what's going on here is that in React 19, ref just becomes like any other prop. So we no longer needs a special type param for it.

Jul 30 2025, 6:31 PM
ashoat requested changes to D14979: [native][RN79][skip-ci] Remove expo-secure-store.

Requesting changes for Podfile updates

Jul 30 2025, 12:48 PM
ashoat requested changes to D14953: [native][RN79][skip-ci] Update to react-native-reanimated@3.17.5.

I think it will be easier to track work here if I request changes for the task creation, that way @angelika knows where in the stack there are to-dos

Jul 30 2025, 12:47 PM
ashoat requested changes to D15007: [Flow262][skip-ci] Replace React$Ref -> React.RefSetter/RefObject.

This doesn't feel right. React.Ref and React.ElementRef are different. Why are we replacing them?

Jul 30 2025, 12:46 PM

Jul 29 2025

ashoat added inline comments to D15161: [web][native] handle QueuedDMOperations for the backup.
Jul 29 2025, 1:32 PM
ashoat added a comment to D14979: [native][RN79][skip-ci] Remove expo-secure-store.

There is a code in Podfile that says it's needed to compile expo secure store in Notification Service. I tried to remove it, but I was getting errors like "sharedApplication not available for use in an App Extension". My guess is the notification service still compiles some RN stuff.

Jul 29 2025, 12:42 PM
ashoat added inline comments to D14976: [native][RN79][skip-ci] Update native files on iOS.
Jul 29 2025, 12:40 PM
ashoat added inline comments to D14976: [native][RN79][skip-ci] Update native files on iOS.
Jul 29 2025, 12:39 PM
ashoat added a comment to D14953: [native][RN79][skip-ci] Update to react-native-reanimated@3.17.5.

The new patch fixes this issue: https://github.com/software-mansion/react-native-reanimated/issues/7109#issuecomment-2841588588

Jul 29 2025, 12:28 PM
ashoat added a comment to D14952: [native][RN79][skip-ci] Update React Native patchfile.

Created ENG-11033 to track eventually making the image pasting work in the new arch

Jul 29 2025, 12:27 PM

Jul 24 2025

ashoat empowered tomek as an administrator.
Jul 24 2025, 4:43 PM
ashoat added a comment to D15093: [lib] Inform other own devices about the connection update.

Spoke to @tomek about this offline, we're going to make this message encrypted if it's easy

Jul 24 2025, 3:40 PM

Jul 21 2025

ashoat added a comment to D14974: [SQLite] populate message search index when restoring backup.

If some JS logic is "duplicated" here in C++, we should add comments to both sides to make sure the implementations don't diverge

Jul 21 2025, 1:21 PM

Jul 16 2025

ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Nice work! Looks good to me :)

Jul 16 2025, 1:01 PM
ashoat added a comment to D14919: [web] Display PushNotif modal after restoration has finished.

If yes, we'll sooner or later catch them, and apply this logic

Jul 16 2025, 12:58 PM

Jul 15 2025

ashoat committed rCOMMf878bd7a3601: [terraform] Bump keyserver image to 1.0.174.
Jul 15 2025, 6:48 PM
ashoat committed rCOMM33b0cda32598: Revert "[native] Temporary changes for staff release".
Jul 15 2025, 4:14 PM
ashoat added a reverting change for rCOMM56db72408a4f: [native] Temporary changes for staff release: rCOMM33b0cda32598: Revert "[native] Temporary changes for staff release".
Jul 15 2025, 4:14 PM
ashoat committed rCOMM56db72408a4f: [native] Temporary changes for staff release.
Jul 15 2025, 4:14 PM
ashoat committed rCOMM47cd2652622b: [native] codeVersion -> 508.
Jul 15 2025, 4:14 PM
ashoat committed rCOMMe6666c755287: [native] codeVersion -> 507.
Jul 15 2025, 4:14 PM
ashoat committed rCOMM43547f42d782: [web][keyserver] codeVersion -> 174.
Jul 15 2025, 4:14 PM
ashoat accepted D14930: [lib] avoid setting cookie to anonymous before state is loaded.
Jul 15 2025, 2:40 PM
ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Thanks! This looks great :)

Jul 15 2025, 1:42 PM
ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Okay, let's try this to keep the height consistent, even for the error screen:

Jul 15 2025, 5:17 AM

Jul 14 2025

ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Thanks, this looks better!

Jul 14 2025, 1:39 PM
ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Thanks, this looks way better! We're almost there... only thing left is to align the dimensions. I feel strongly that dimensions of a modal should not randomly change in size. It's okay that it looks kind of empty, we can eg. vertical-align the progress step indicator to make it look better. Additionally, realizing that the process of the subtitle in the header in only some cases (not on the starting screen) will be weird, so probably best to move the subtitle below the "underline" that appears under the header, so that the underline looks look like it jumps around.

Jul 14 2025, 12:53 PM

Jul 11 2025

ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

UI feedback

Jul 11 2025, 3:01 PM
ashoat resigned from D14915: [native] Show alert when DB is corrupt on app startup.

Copy looks good!

Jul 11 2025, 2:55 PM

Jul 10 2025

ashoat added a comment to D14911: [native] Connect Farcaster DCs during registration.

The current text is a little long. I've tried to suggest shorter phrases below

Jul 10 2025, 2:13 PM

Jul 8 2025

ashoat added inline comments to D14900: [lib] Create a Farcaster message signer.
Jul 8 2025, 2:33 PM

Jul 7 2025

ashoat closed D14897: [keyserver] Script to transfer admin permissions.
Jul 7 2025, 3:09 PM
ashoat committed rCOMM155630434852: [keyserver] Script to transfer admin permissions.
Jul 7 2025, 3:09 PM

Jul 6 2025

ashoat requested review of D14897: [keyserver] Script to transfer admin permissions.
Jul 6 2025, 2:03 AM

Jul 1 2025

ashoat committed rCOMMbf4008cd3c01: [terraform] Bump keyserver image to 1.0.173.
Jul 1 2025, 3:46 PM
ashoat committed rCOMMa76b785e33e4: Revert "[native] Temporary changes for staff release".
Jul 1 2025, 3:21 PM
ashoat added a reverting change for rCOMMabfd30384bae: [native] Temporary changes for staff release: rCOMMa76b785e33e4: Revert "[native] Temporary changes for staff release".
Jul 1 2025, 3:21 PM
ashoat committed rCOMMbf6dc411fcaf: [native] codeVersion -> 506.
Jul 1 2025, 3:21 PM
ashoat committed rCOMMabfd30384bae: [native] Temporary changes for staff release.
Jul 1 2025, 3:21 PM
ashoat committed rCOMMf27d371b1ef1: [native] codeVersion -> 505.
Jul 1 2025, 3:21 PM
ashoat committed rCOMMeab9c55a8764: [web][keyserver] codeVersion -> 173.
Jul 1 2025, 3:21 PM

Jun 30 2025

ashoat closed D14869: [keyserver] Fix CORS domain type.
Jun 30 2025, 10:42 PM
ashoat committed rCOMM89b551132c94: [keyserver] Fix CORS domain type.
Jun 30 2025, 10:42 PM
ashoat closed D14870: [lib] Return own messages from fetchMessageNotifyType.
Jun 30 2025, 10:42 PM
ashoat committed rCOMMa06ebef88cb7: [lib] Return own messages from fetchMessageNotifyType.
Jun 30 2025, 10:42 PM

Jun 29 2025

ashoat requested review of D14869: [keyserver] Fix CORS domain type.
Jun 29 2025, 7:00 PM
ashoat requested review of D14870: [lib] Return own messages from fetchMessageNotifyType.
Jun 29 2025, 6:59 PM

Jun 15 2025

ashoat closed D14839: [keyserver] Don't crash in socket on responseTo = 0.
Jun 15 2025, 3:46 AM
ashoat committed rCOMM41c725083337: [keyserver] Don't crash in socket on responseTo = 0.
Jun 15 2025, 3:46 AM

Jun 12 2025

ashoat requested review of D14839: [keyserver] Don't crash in socket on responseTo = 0.
Jun 12 2025, 4:10 PM

Jun 11 2025

ashoat committed rCOMMb7d4ece15596: [terraform] Bump keyserver image to 1.0.172.
Jun 11 2025, 2:10 AM
ashoat added a reverting change for rCOMM03b9a874fc71: [native] Temporary changes for staff release: rCOMM2396f62dfe39: Revert "[native] Temporary changes for staff release".
Jun 11 2025, 1:48 AM
ashoat committed rCOMM2396f62dfe39: Revert "[native] Temporary changes for staff release".
Jun 11 2025, 1:48 AM
ashoat committed rCOMMea4cd66d5c04: [native] codeVersion -> 504.
Jun 11 2025, 1:47 AM
ashoat committed rCOMM03b9a874fc71: [native] Temporary changes for staff release.
Jun 11 2025, 1:47 AM
ashoat committed rCOMMfd2beac748cd: [native] codeVersion -> 503.
Jun 11 2025, 1:47 AM
ashoat committed rCOMM872a2fb512c8: [web][keyserver] codeVersion -> 172.
Jun 11 2025, 1:47 AM

Jun 8 2025

ashoat added a comment to D14817: [lib] Disable sending svg and tiff images on web.

Thanks, makes sense. Wonder if we should rename serverCanHandle to canHandle and serverTranscodesImage to canTranscodeImage, since it's not really server-related anymore

Jun 8 2025, 12:32 PM

Jun 7 2025

ashoat added a comment to D14817: [lib] Disable sending svg and tiff images on web.

Does this disable it just for images sent in thin threads on web, where (I think) we use sharp on the keyserver for transcoding? Or does it disable it more globally, eg. in thick threads, or in thin threads sent from mobile?

Jun 7 2025, 2:02 PM
ashoat accepted D14817: [lib] Disable sending svg and tiff images on web.
Jun 7 2025, 2:00 PM

Jun 6 2025

ashoat accepted D14816: [lib] Fetch keys only when a session is missing.
Jun 6 2025, 1:01 PM
ashoat published D14816: [lib] Fetch keys only when a session is missing for review.
Jun 6 2025, 1:01 PM

Jun 5 2025

ashoat accepted D14812: [native] fix simultaneous promises in `SQLiteDataHandler`.
Jun 5 2025, 1:39 PM

Jun 3 2025

ashoat accepted D14792: [lib][web][native] prompt the user that app is out-of-date when restoring.
Jun 3 2025, 2:52 PM

May 30 2025

ashoat added inline comments to D14792: [lib][web][native] prompt the user that app is out-of-date when restoring.
May 30 2025, 4:18 PM
ashoat added inline comments to D14792: [lib][web][native] prompt the user that app is out-of-date when restoring.
May 30 2025, 3:57 PM

May 28 2025

ashoat accepted D14784: [native] Define alert messages for restoration errors.

Looks good!

May 28 2025, 8:44 PM
ashoat accepted D14779: [web][native] Display network error alert in QR flow.

Copy looks great!

May 28 2025, 10:27 AM
ashoat accepted D14778: [native] Display network error alert during restore flow.

Copy looks great!

May 28 2025, 10:27 AM
ashoat accepted D14758: [proto] Add devices filter param to X3DH RPC requests.
May 28 2025, 7:35 AM

May 25 2025

ashoat committed rCOMM499e8d0123f5: Revert "[native] Temporary changes for staff release".
May 25 2025, 4:18 AM
ashoat added a reverting change for rCOMM89ea30ea5045: [native] Temporary changes for staff release: rCOMM499e8d0123f5: Revert "[native] Temporary changes for staff release".
May 25 2025, 4:18 AM
ashoat committed rCOMM1acd3c5dc5f5: [native] codeVersion -> 502.
May 25 2025, 4:18 AM
ashoat committed rCOMM89ea30ea5045: [native] Temporary changes for staff release.
May 25 2025, 4:18 AM

May 24 2025

ashoat committed rCOMMfd6105987bda: [terraform] Bump keyserver image to 1.0.171.
May 24 2025, 9:58 PM
ashoat committed rCOMMddf2d6361ba2: Revert "[native] Temporary changes for staff release".
May 24 2025, 9:40 PM
ashoat added a reverting change for rCOMM1aa26161f86f: [native] Temporary changes for staff release: rCOMMddf2d6361ba2: Revert "[native] Temporary changes for staff release".
May 24 2025, 9:40 PM
ashoat committed rCOMM1c81d2d030b4: [native] codeVersion -> 500.
May 24 2025, 9:40 PM
ashoat committed rCOMM1aa26161f86f: [native] Temporary changes for staff release.
May 24 2025, 9:40 PM
ashoat committed rCOMM7253744e2138: [native] codeVersion -> 499.
May 24 2025, 9:40 PM
ashoat committed rCOMMfbe8fe213273: [web][keyserver] codeVersion -> 171.
May 24 2025, 9:40 PM
ashoat committed rCOMM0369d581a222: [landing] Update ToS.
May 24 2025, 9:40 PM

May 20 2025

ashoat committed rCOMMc52c33f4690e: [terraform] Bump keyserver image to 1.0.170.
May 20 2025, 1:20 PM
ashoat added a reverting change for rCOMM746c8052d143: [native] Temporary changes for staff release: rCOMM611a45f458c9: Revert "[native] Temporary changes for staff release".
May 20 2025, 12:38 PM
ashoat committed rCOMM611a45f458c9: Revert "[native] Temporary changes for staff release".
May 20 2025, 12:38 PM
ashoat committed rCOMMdde6264e7350: [native] codeVersion -> 498.
May 20 2025, 12:37 PM
ashoat committed rCOMM746c8052d143: [native] Temporary changes for staff release.
May 20 2025, 12:37 PM
ashoat committed rCOMM8e4b0382c144: [native] codeVersion -> 497.
May 20 2025, 12:37 PM
ashoat committed rCOMM8506b19a1700: [web][keyserver] codeVersion -> 170.
May 20 2025, 12:37 PM
ashoat committed rCOMM9f5024aa6d60: [terraform] Bump keyserver image to 1.0.169.
May 20 2025, 2:12 AM
ashoat added a reverting change for rCOMM97a90cc0bf2f: [native] Temporary changes for staff release: rCOMM9231490c9397: Revert "[native] Temporary changes for staff release".
May 20 2025, 1:37 AM
ashoat committed rCOMM9231490c9397: Revert "[native] Temporary changes for staff release".
May 20 2025, 1:37 AM
ashoat committed rCOMM7962f49c7a3f: [native] codeVersion -> 496.
May 20 2025, 1:37 AM
ashoat committed rCOMM97a90cc0bf2f: [native] Temporary changes for staff release.
May 20 2025, 1:37 AM
ashoat committed rCOMMd70636c421a3: [native] codeVersion -> 495.
May 20 2025, 1:37 AM
ashoat committed rCOMM044695137647: [web][keyserver] codeVersion -> 169.
May 20 2025, 1:36 AM

May 19 2025

ashoat accepted D14713: [native] Respect the session overriding.
May 19 2025, 11:59 AM

May 18 2025

ashoat committed rCOMM0c88031462bd: [native][web] Pretty-print copied debug logs.
May 18 2025, 1:19 PM

May 17 2025

ashoat committed rCOMMb5f357e8fc4f: [terraform] Bump keyserver image to 1.0.168.
May 17 2025, 12:25 PM