In D7716#228907, @ashoat wrote:

I believe @inka introduced CommunityPicker, so she should definitely be on the review

Accepting, but would be good to double check that you intended to set useBlobServiceUploads to true here.

Requesting changes for base64/base64url encoding feedback.

Looks good, couple of notes inline that would be good to get a response to but not necessarily actionable

Requesting changes to ensure we correctly convert base64 encoding to base64url.

Uploaded both encrypted and non-encrypted blob to local blob service instance. Amended the keyserver's upload-fetchers to return these Blob URIs. Verified media is fetched and displayed correctly both on web and native.

Thanks! I'll take a look and give it a go

Can we get rid of the React.useMemo(...) here?

Looks okay at a high level, adding @ashoat as blocking since I'm not super familiar with navigation (particularly wrt flow types)

Left some high level feedback. Adding @ashoat as blocking to take a look at the navigation stuff (I'm not super familiar with how navigation works, but it looks right?)

cut console.log

rebase before addressing feedback

rebase and land

pass filesystem.unlink directly into forEach

Also, can we not pass filesystem.unlink in directly, without needing an extra lambda?

make sure it's right

resolve merge conflicts

move UpdateUserAvatarResponse alongside UpdateUserAvatarRequest in avatar-types

rebase BEFORE addressing feedback

fix flow (will wait for buildkite CI to complete before landing)

Okay so when I ran flow in keyserver, there were no issues. Then I ran it again AFTER yarn cleaninstall && killall flow and it gave me the three issues... so I guess got in some bad state? Hopefully a one-off issue

re-opening....

Re-opening to address flow issues...

address feedback

address feedback (i think)

address feedback (i think)

address feedback

rebase and land

fix

address feedback

Thanks, I should've considered this

We can just abandon

rebase and land

rebase and land

rebase and alnd

update