The build fails because of https://linear.app/comm/issue/ENG-6910/buildkite-ios-build-failing-on-canal-runner#comment-05ad83c2
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 23 2024
Rename
authoritativeKeyserverID may not be present. The types already handle this correctly
Fix imports
Update comment
keyserverAuth action has a defined currentUserInfo only if it was sent by the authoritative keyserver
Set avatar and settings on keyserver auth
Rebase
Feb 22 2024
You also need to remove actualizedCalendarQuery from states on web and native. And then from default states.
Work around keys being in different shapes on ks and clients
Hanlde folders not existing
Feb 21 2024
Have rust bindings use IdentityInfo, because napi-rs converts user_id to userId
We only need to use userID in places where we get data from CommServicesAuthMetadataEmitter
Address review
Address review
Address review - I forced a state sync and checked that a cached value is used
Address review. I tested that the query still executes correctly for both uuid and a number like id
Fix test description
Rename sortIDs to sortUserIDs, make the relationship transitive
Feb 20 2024
Turn genesis into a funtion - in lib we cannot call authoritativeKeyserverID top level, because configs are not registered yet
Use value from web - we dno't need to get the value from config, we can use the value from the env variable. This will let us use authoritativeKeyserverID toplevel on web
Use value from natvie - we don't need to fetch the value from config on native. We want to use the value fetched from the config, to be able to use it top level
Replace with function call - this is needed to ensure the value is read after the config is set.
We want to use authoritativeKeyserverID from web on web
Here is the diff with the remaining files: D11116
Remove flow annotation. I was informed this is how this should be done, hope this is fine
This would take ~3min... I wonder if the amount of time you spent typing this message and creating the task, along with the time I am now spending typing this, is higher than the amount of time it takes you to simply put a diff up that strips the annotations. In this case I don't think the work should have been deferred. It's less a question of prioritization, and more a question of using your time and my time wisely.
Feb 19 2024
Handle errors
We decided to have one source of truth and just fetch the data from the db.
Feb 15 2024
Rebase and update new usages of ashoatKeyserverID
Feb 14 2024
In the keyserver we:
- need a file with admins id (ENG-6614)
- need a file with admins username and password - user_credentials.json
- wanted to add a flag to user_credentials.json that would tell the keyserver if it should use its id, or 256
I think we can merge these and add id to user_credentials.json, and if present, use it.
Feb 13 2024
Check if the keyserver can use its id when communicating with clients
Some devs already have identity info in their dbs, this code will result in the id from the db being used instead of ashoatKeyserverID. This is not good, because the clients have ids prefixed with 256, so input validation will fail, and data sent by the server would be prefixed incorrectly, until the clients configure theis authoritativeKeyserverID. I need to handle this case
Go back to initial approach.
Feb 12 2024
Address review
Address review
This code is quite complex in the case you were not able to test - when we connect to a different keyserver, and even mo so when we connect to a couple of keyservers. I can see that it would be hard to test now, but it would be great if you could create a linear task describing how this should be tested once it's possible, and set it as blocked by appropriate tasks.