Page MenuHomePhabricator
Feed Advanced Search

Feb 23 2024

inka added a comment to D11157: [native] Fix hermes throwing on nonexistant files.

The build fails because of https://linear.app/comm/issue/ENG-6910/buildkite-ios-build-failing-on-canal-runner#comment-05ad83c2

Feb 23 2024, 7:37 AM
inka requested review of D11157: [native] Fix hermes throwing on nonexistant files.
Feb 23 2024, 7:17 AM
inka closed D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 23 2024, 4:35 AM
inka closed D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.
Feb 23 2024, 4:35 AM
inka committed rCOMM5a38af1e5a29: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat (authored by inka).
[lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat
Feb 23 2024, 4:35 AM
inka committed rCOMM451f0c2b8c96: [lib] reduce currentUserInfo on identity login/register (authored by inka).
[lib] reduce currentUserInfo on identity login/register
Feb 23 2024, 4:35 AM
inka closed D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.
Feb 23 2024, 4:35 AM
inka closed D11105: [keyserver] Replace ashoat with admin.
Feb 23 2024, 4:35 AM
inka closed D11116: [scripts] Remove flow annotation.
Feb 23 2024, 4:35 AM
inka committed rCOMM0bdd01b5fe49: [keyserver][lib] Make updates code aware that ids are strings, not numbers (authored by inka).
[keyserver][lib] Make updates code aware that ids are strings, not numbers
Feb 23 2024, 4:35 AM
inka closed D11075: [scripts] Create a script for configuring user credentials.
Feb 23 2024, 4:35 AM
inka committed rCOMM0a0ba7aa6f7c: [keyserver] Replace ashoat with admin (authored by inka).
[keyserver] Replace ashoat with admin
Feb 23 2024, 4:35 AM
inka committed rCOMM467af97c2dd5: [scripts] Remove flow annotation (authored by inka).
[scripts] Remove flow annotation
Feb 23 2024, 4:35 AM
inka committed rCOMM86b7b5e18a4c: [scripts] Create a script for configuring user credentials (authored by inka).
[scripts] Create a script for configuring user credentials
Feb 23 2024, 4:35 AM
inka closed D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 23 2024, 4:35 AM
inka closed D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 23 2024, 4:35 AM
inka closed D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 23 2024, 4:35 AM
inka committed rCOMMd303d990d9ba: [lib] Update genesis.id to use authoritativeKeyserverID (authored by inka).
[lib] Update genesis.id to use authoritativeKeyserverID
Feb 23 2024, 4:34 AM
inka committed rCOMMa71b22170f0a: [web] Replace ashoatKeyserverID with authoritativeKeyserverID (authored by inka).
[web] Replace ashoatKeyserverID with authoritativeKeyserverID
Feb 23 2024, 4:34 AM
inka committed rCOMM7bbae1f9ede3: [keyserver] Replace ashoatKeyserverID with thisKeyserverID() (authored by inka).
[keyserver] Replace ashoatKeyserverID with thisKeyserverID()
Feb 23 2024, 4:34 AM
inka closed D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 23 2024, 4:34 AM
inka closed D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 23 2024, 4:34 AM
inka committed rCOMM165dd42e51f2: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID (authored by inka).
[lib] Replace ashoatKeyserverID with authoritativeKeyserverID
Feb 23 2024, 4:34 AM
inka committed rCOMMbe19f2e6203e: [native] Replace ashoatKeyserverID with authoritativeKeyserverID (authored by inka).
[native] Replace ashoatKeyserverID with authoritativeKeyserverID
Feb 23 2024, 4:34 AM
inka closed D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 23 2024, 4:34 AM
inka committed rCOMM9c9b9d26a8e6: [lib][web][native] Add configurable authoritativeKeyserverID (authored by inka).
[lib][web][native] Add configurable authoritativeKeyserverID
Feb 23 2024, 4:34 AM
inka updated the diff for D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.

Rename

Feb 23 2024, 4:09 AM
inka updated the diff for D11140: [lib] reduce currentUserInfo on identity login/register.

authoritativeKeyserverID may not be present. The types already handle this correctly

Feb 23 2024, 4:01 AM
inka added inline comments to D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 23 2024, 4:00 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Fix imports

Feb 23 2024, 3:50 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Update comment

Feb 23 2024, 3:08 AM
inka added inline comments to D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 23 2024, 3:03 AM
inka added a comment to D11140: [lib] reduce currentUserInfo on identity login/register.

keyserverAuth action has a defined currentUserInfo only if it was sent by the authoritative keyserver

Feb 23 2024, 1:10 AM
inka added inline comments to D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 23 2024, 1:10 AM
inka updated the diff for D11140: [lib] reduce currentUserInfo on identity login/register.

Set avatar and settings on keyserver auth

Feb 23 2024, 1:09 AM
inka added inline comments to D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 23 2024, 12:23 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase

Feb 23 2024, 12:21 AM

Feb 22 2024

inka requested review of D11146: [lib] Update getDefaultAvatar and threadMembersWithoutAddedAshoat.
Feb 22 2024, 11:36 PM
inka added inline comments to D11141: [IGNORE] Client hacks for testing multiple keyservers.
Feb 22 2024, 7:49 AM
inka requested changes to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 22 2024, 7:14 AM
inka added inline comments to D11144: [lib] Move actualizedCalendarQuery into keyserver store.
Feb 22 2024, 7:11 AM
inka added a comment to D11144: [lib] Move actualizedCalendarQuery into keyserver store.

You also need to remove actualizedCalendarQuery from states on web and native. And then from default states.

Feb 22 2024, 7:05 AM
inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Work around keys being in different shapes on ks and clients

Feb 22 2024, 6:53 AM
inka requested review of D11141: [IGNORE] Client hacks for testing multiple keyservers.
Feb 22 2024, 4:21 AM
inka updated the diff for D11075: [scripts] Create a script for configuring user credentials.

Hanlde folders not existing

Feb 22 2024, 3:19 AM
inka accepted D11092: [lib] Make activity-handler keyserver-specific.
Feb 22 2024, 2:07 AM
inka requested review of D11140: [lib] reduce currentUserInfo on identity login/register.
Feb 22 2024, 12:59 AM
inka closed D11134: [keyserver][lib][native] Rename userId -> userID.
Feb 22 2024, 12:33 AM
inka committed rCOMM965e8c265133: [keyserver][lib][native] Rename userId -> userID (authored by inka).
[keyserver][lib][native] Rename userId -> userID
Feb 22 2024, 12:33 AM

Feb 21 2024

inka updated the diff for D11134: [keyserver][lib][native] Rename userId -> userID.

Have rust bindings use IdentityInfo, because napi-rs converts user_id to userId
We only need to use userID in places where we get data from CommServicesAuthMetadataEmitter

Feb 21 2024, 9:22 AM
inka planned changes to D11134: [keyserver][lib][native] Rename userId -> userID.
Feb 21 2024, 9:09 AM
inka requested review of D11134: [keyserver][lib][native] Rename userId -> userID.
Feb 21 2024, 8:00 AM
inka updated the diff for D10993: [lib][web][native] Add configurable authoritativeKeyserverID.

Address review

Feb 21 2024, 5:48 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Address review

Feb 21 2024, 5:43 AM
inka accepted D11128: [native] Don't dispatch an undefined token.
Feb 21 2024, 5:36 AM
inka added inline comments to D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 21 2024, 3:42 AM
inka accepted D11094: [lib] Make update-handler keyserver-specific.
Feb 21 2024, 2:37 AM
inka added inline comments to D11105: [keyserver] Replace ashoat with admin.
Feb 21 2024, 2:07 AM
inka updated the diff for D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

Address review - I forced a state sync and checked that a cached value is used

Feb 21 2024, 2:05 AM
inka added inline comments to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 21 2024, 1:59 AM
inka updated the diff for D11105: [keyserver] Replace ashoat with admin.

Address review. I tested that the query still executes correctly for both uuid and a number like id

Feb 21 2024, 1:25 AM
inka updated the diff for D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.

Fix test description

Feb 21 2024, 1:04 AM
inka updated the diff for D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.

Rename sortIDs to sortUserIDs, make the relationship transitive

Feb 21 2024, 12:58 AM
inka added inline comments to D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.
Feb 21 2024, 12:58 AM

Feb 20 2024

inka requested review of D11011: [lib] Update genesis.id to use authoritativeKeyserverID.
Feb 20 2024, 4:40 AM
inka updated the diff for D11011: [lib] Update genesis.id to use authoritativeKeyserverID.

Turn genesis into a funtion - in lib we cannot call authoritativeKeyserverID top level, because configs are not registered yet

Feb 20 2024, 4:40 AM
inka requested review of D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 20 2024, 4:28 AM
inka updated the diff for D11008: [web] Replace ashoatKeyserverID with authoritativeKeyserverID.

Use value from web - we dno't need to get the value from config, we can use the value from the env variable. This will let us use authoritativeKeyserverID toplevel on web

Feb 20 2024, 4:28 AM
inka requested review of D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 20 2024, 4:23 AM
inka updated the diff for D11007: [native] Replace ashoatKeyserverID with authoritativeKeyserverID.

Use value from natvie - we don't need to fetch the value from config on native. We want to use the value fetched from the config, to be able to use it top level

Feb 20 2024, 4:23 AM
inka requested review of D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.
Feb 20 2024, 4:20 AM
inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Replace with function call - this is needed to ensure the value is read after the config is set.

Feb 20 2024, 4:19 AM
inka requested review of D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 20 2024, 4:00 AM
inka updated the diff for D10993: [lib][web][native] Add configurable authoritativeKeyserverID.

We want to use authoritativeKeyserverID from web on web

Feb 20 2024, 3:48 AM
inka requested review of D11116: [scripts] Remove flow annotation.
Feb 20 2024, 3:28 AM
inka added a comment to D11075: [scripts] Create a script for configuring user credentials.

Here is the diff with the remaining files: D11116

Feb 20 2024, 3:14 AM
inka updated the diff for D11075: [scripts] Create a script for configuring user credentials.

Remove flow annotation. I was informed this is how this should be done, hope this is fine

Feb 20 2024, 3:07 AM
inka added inline comments to D11075: [scripts] Create a script for configuring user credentials.
Feb 20 2024, 12:22 AM
inka added a comment to D11075: [scripts] Create a script for configuring user credentials.

This would take ~3min... I wonder if the amount of time you spent typing this message and creating the task, along with the time I am now spending typing this, is higher than the amount of time it takes you to simply put a diff up that strips the annotations. In this case I don't think the work should have been deferred. It's less a question of prioritization, and more a question of using your time and my time wisely.

Feb 20 2024, 12:09 AM

Feb 19 2024

inka requested review of D11105: [keyserver] Replace ashoat with admin.
Feb 19 2024, 5:18 AM
inka requested review of D11104: [keyserver][lib] Make updates code aware that ids are strings, not numbers.
Feb 19 2024, 5:07 AM
inka updated the diff for D11075: [scripts] Create a script for configuring user credentials.

Handle errors

Feb 19 2024, 3:31 AM
inka updated the diff for D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

We decided to have one source of truth and just fetch the data from the db.

Feb 19 2024, 3:29 AM
inka added inline comments to D11075: [scripts] Create a script for configuring user credentials.
Feb 19 2024, 3:25 AM

Feb 15 2024

inka updated the diff for D11006: [lib] Replace ashoatKeyserverID with authoritativeKeyserverID.

Rebase and update new usages of ashoatKeyserverID

Feb 15 2024, 3:36 AM
inka accepted D11088: [keyserver] Log the exception when failing to synchronize links with blobs.
Feb 15 2024, 3:15 AM

Feb 14 2024

inka accepted D11076: [keyserver] Create invite link blobs in a migration.
Feb 14 2024, 7:46 AM
inka requested review of D11075: [scripts] Create a script for configuring user credentials.
Feb 14 2024, 6:47 AM
inka updated the diff for D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

In the keyserver we:

  • need a file with admins id (ENG-6614)
  • need a file with admins username and password - user_credentials.json
  • wanted to add a flag to user_credentials.json that would tell the keyserver if it should use its id, or 256

I think we can merge these and add id to user_credentials.json, and if present, use it.

Feb 14 2024, 5:12 AM

Feb 13 2024

inka added a comment to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

In here @ashoat suggested putting this flag in user_credentials.json

Feb 13 2024, 8:05 AM
inka updated the diff for D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

Check if the keyserver can use its id when communicating with clients

Feb 13 2024, 3:57 AM
inka added a comment to D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

Some devs already have identity info in their dbs, this code will result in the id from the db being used instead of ashoatKeyserverID. This is not good, because the clients have ids prefixed with 256, so input validation will fail, and data sent by the server would be prefixed incorrectly, until the clients configure theis authoritativeKeyserverID. I need to handle this case

Feb 13 2024, 2:50 AM
inka updated the summary of D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 13 2024, 2:45 AM
inka updated the diff for D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().

Go back to initial approach.

Feb 13 2024, 2:44 AM
inka requested review of D11050: [keyserver] Replace ashoatKeyserverID with thisKeyserverID().
Feb 13 2024, 2:37 AM

Feb 12 2024

inka updated the diff for D10993: [lib][web][native] Add configurable authoritativeKeyserverID.

Address review

Feb 12 2024, 9:17 AM
inka added inline comments to D10993: [lib][web][native] Add configurable authoritativeKeyserverID.
Feb 12 2024, 9:17 AM
inka updated the diff for D11011: [lib] Update genesis.id to use authoritativeKeyserverID.

Address review

Feb 12 2024, 8:02 AM
inka accepted D10992: [lib] Join a community on an overridden keyserver.

This code is quite complex in the case you were not able to test - when we connect to a different keyserver, and even mo so when we connect to a couple of keyservers. I can see that it would be hard to test now, but it would be great if you could create a linear task describing how this should be tested once it's possible, and set it as blocked by appropriate tasks.

Feb 12 2024, 6:49 AM
inka accepted D10991: [native][web][lib] Extract common invite link logic.
Feb 12 2024, 2:45 AM