Page MenuHomePhabricator
Differential D11076

[keyserver] Create invite link blobs in a migration
ClosedPublic
Actions

Authored by tomek on Feb 14 2024, 7:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 5:01 PM
Unknown Object (File)
Sun, Mar 9, 10:41 AM
Unknown Object (File)
Tue, Feb 25, 6:36 PM
Unknown Object (File)
Feb 24 2025, 12:12 AM
Unknown Object (File)
Feb 24 2025, 12:12 AM
Unknown Object (File)
Feb 24 2025, 12:12 AM
Unknown Object (File)
Feb 23 2025, 6:17 AM
Unknown Object (File)
Feb 21 2025, 9:25 AM
View All 81 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
inka
Commits
rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration
Summary

In D10206 we're running this in cron, but we also should do that in a migration - this isn't strictly necessary because cron would update it later, but it is better to do that immediately.

Additionally, the function was modified so that the migration / job doesn't fail in environments where we aren't authenticated to Identity service.

Depends on D11051

Test Plan

Run the keyserver and check if the migration creates holders in invite_links table.
Kill the keyserver, delete auth metadata, decrement db version, delete the holder and update invite link secret. Then run the keyserver - the migration should succeed by printing an error message - the holder shouldn't be created.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Feb 14 2024, 7:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 14 2024, 7:05 AM
tomek removed a reviewer: varun.Feb 14 2024, 7:11 AM
Harbormaster completed remote builds in B26834: Diff 37077.Feb 14 2024, 7:20 AM
tomek requested review of this revision.Feb 14 2024, 7:21 AM
inka accepted this revision.Feb 14 2024, 7:46 AM
This revision is now accepted and ready to land.Feb 14 2024, 7:46 AM
Closed by commit rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration.
ashoat added inline comments.Feb 14 2024, 11:36 AM
keyserver/src/utils/synchronizeInviteLinksWithBlobs.js
44

Will monitor for this string next time I deploy the keyserver

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
2 lines
utils/
6 lines

Diff 37098

View Options

keyserver/src/database/migration-config.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

keyserver/src/utils/synchronizeInviteLinksWithBlobs.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines