[keyserver] Create a function that downloads blobs
ClosedPublic
Actions

Authored by tomek on Nov 21 2023, 7:48 AM.

Details

Reviewers

kamil
marcin
bartek

Commits

rCOMM174754d3184f: [keyserver] Create a function that downloads blobs

Summary

This function takes a hash as a parameter and returns a blob.

Depends on D9941

Test Plan

Create a script that creates a blob and then downloads it - check if the right payload is received.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Nov 21 2023, 7:48 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 21 2023, 7:48 AM

tomek added a child revision: D9943: [keyserver] Check if a blob exists.Nov 21 2023, 8:05 AM

Harbormaster completed remote builds in B24306: Diff 33458.Nov 21 2023, 8:08 AM

tomek requested review of this revision.Nov 21 2023, 8:08 AM

marcin accepted this revision.Nov 22 2023, 6:49 AM

This revision is now accepted and ready to land.Nov 22 2023, 6:49 AM

Closed by commit rCOMM174754d3184f: [keyserver] Create a function that downloads blobs (authored by tomek). · Explain WhyNov 24 2023, 4:51 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM174754d3184f: [keyserver] Create a function that downloads blobs.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

blob.js

18 lines

Diff 33582

View Options

keyserver/src/services/blob.js

This file was copied to services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp.

#pragma once		#pragma once

#include "ClientBidiReactorBase.h"
#include "Constants.h"		#include "Constants.h"

#include "../_generated/blob.grpc.pb.h"		#include "../_generated/blob.grpc.pb.h"
#include "../_generated/blob.pb.h"		#include "../_generated/blob.pb.h"

		#include "ClientBidiReactorBase.h"

#include <folly/MPMCQueue.h>		#include <folly/MPMCQueue.h>
#include <grpcpp/grpcpp.h>		#include <grpcpp/grpcpp.h>

#include <condition_variable>		#include <condition_variable>
#include <iostream>
#include <memory>		#include <memory>
#include <string>		#include <string>

namespace comm {		namespace comm {
namespace network {		namespace network {
namespace reactor {		namespace reactor {

class BlobPutClientReactor		class BlobPutClientReactor
Show All 22 Lines	public:
void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);		void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);
std::unique_ptr<grpc::Status> prepareRequest(		std::unique_ptr<grpc::Status> prepareRequest(
blob::PutRequest &request,		blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) override;		std::shared_ptr<blob::PutResponse> previousResponse) override;
void doneCallback() override;		void doneCallback() override;
grpc::Status getStatus() const;		grpc::Status getStatus() const;
};		};

BlobPutClientReactor::BlobPutClientReactor(
const std::string &holder,
const std::string &hash,
std::condition_variable *terminationNotifier)
: holder(holder),
hash(hash),
dataChunks(folly::MPMCQueue<std::string>(100)),
terminationNotifier(terminationNotifier) {
}

void BlobPutClientReactor::scheduleSendingDataChunk(
std::unique_ptr<std::string> dataChunk) {
if (!this->dataChunks.write(std::move(*dataChunk))) {
throw std::runtime_error(
"Error scheduling sending a data chunk to send to the blob service");
}
}

std::unique_ptr<grpc::Status> BlobPutClientReactor::prepareRequest(
blob::PutRequest &request,
std::shared_ptr<blob::PutResponse> previousResponse) {
if (this->state == State::SEND_HOLDER) {
this->request.set_holder(this->holder);
this->state = State::SEND_HASH;
return nullptr;
}
if (this->state == State::SEND_HASH) {
request.set_blobhash(this->hash);
this->state = State::SEND_CHUNKS;
return nullptr;
}
if (previousResponse->dataexists()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
std::string dataChunk;
this->dataChunks.blockingRead(dataChunk);
if (dataChunk.empty()) {
return std::make_unique<grpc::Status>(grpc::Status::OK);
}
request.set_datachunk(dataChunk);
return nullptr;
}

void BlobPutClientReactor::doneCallback() {
this->terminationNotifier->notify_one();
}

grpc::Status BlobPutClientReactor::getStatus() const {
return this->status;
}

} // namespace reactor		} // namespace reactor
} // namespace network		} // namespace network
} // namespace comm		} // namespace comm

[keyserver] Create a function that downloads blobsClosedPublicActions