Page MenuHomePhabricator

[keyserver] Modify blob functions so that they take params object where both hash and holder are provided
ClosedPublic

Authored by tomek on Nov 30 2023, 7:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 11:18 AM
Unknown Object (File)
Oct 4 2024, 3:12 AM
Unknown Object (File)
Oct 4 2024, 3:12 AM
Unknown Object (File)
Oct 4 2024, 3:12 AM
Unknown Object (File)
Oct 4 2024, 3:12 AM
Unknown Object (File)
Oct 4 2024, 3:11 AM
Unknown Object (File)
Oct 4 2024, 3:11 AM
Unknown Object (File)
Sep 4 2024, 7:45 PM
Subscribers

Details

Summary

The new API makes it less likely to confuse these

Depends on D9972

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Nov 30 2023, 7:28 AM
rohan added inline comments.
keyserver/src/services/blob.js
34 ↗(On Diff #34055)

Not a big deal, but my preference is to destructure in the function rather than in the params (both here, in upload, and in deleteBlob). But you can keep it whatever way you prefer

This revision is now accepted and ready to land.Nov 30 2023, 8:39 AM

Destructure in the function