Page MenuHomePhabricator
Differential D10098

[keyserver] Modify blob functions so that they take params object where both hash and holder are provided
ClosedPublic
Actions

Authored by tomek on Nov 30 2023, 7:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:26 AM
Unknown Object (File)
Wed, Nov 20, 8:17 PM
Unknown Object (File)
Tue, Nov 19, 9:20 PM
Unknown Object (File)
Tue, Nov 19, 5:17 PM
Unknown Object (File)
Tue, Nov 19, 2:12 PM
Unknown Object (File)
Tue, Nov 19, 4:57 AM
Unknown Object (File)
Tue, Nov 19, 3:02 AM
Unknown Object (File)
Mon, Nov 18, 12:56 PM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
rohan
Commits
rCOMM619eea4efb61: [keyserver] Modify blob functions so that they take params object where both…
Summary

The new API makes it less likely to confuse these

Depends on D9972

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Nov 30 2023, 7:08 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 30 2023, 7:08 AM
Harbormaster completed remote builds in B24643: Diff 34055.Nov 30 2023, 7:28 AM
tomek requested review of this revision.Nov 30 2023, 7:28 AM
tomek added a child revision: D10099: [keyserver] Introduce a util function that generates invite link blob hash.Nov 30 2023, 7:38 AM
rohan accepted this revision.Nov 30 2023, 8:39 AM
rohan added inline comments.
keyserver/src/services/blob.js
34 ↗(On Diff #34055)

Not a big deal, but my preference is to destructure in the function rather than in the params (both here, in upload, and in deleteBlob). But you can keep it whatever way you prefer

This revision is now accepted and ready to land.Nov 30 2023, 8:39 AM
tomek updated this revision to Diff 36408.Jan 31 2024, 8:55 AM

Destructure in the function

Harbormaster completed remote builds in B26340: Diff 36408.Jan 31 2024, 9:14 AM
tomek updated this revision to Diff 36847.Feb 8 2024, 6:32 AM

Rebase

Harbormaster completed remote builds in B26650: Diff 36847.Feb 8 2024, 7:01 AM
Closed by commit rCOMM619eea4efb61: [keyserver] Modify blob functions so that they take params object where both… (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM619eea4efb61: [keyserver] Modify blob functions so that they take params object where both….

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
5 lines
services/
19 lines

Diff 37083

View Options

keyserver/src/push/utils.js

Loading...
View Options

keyserver/src/services/blob.js

Loading...