After fetching a blob, check if it exists, and return different result depending on the test.
Depends on D9942
Details
Details
- Reviewers
kamil marcin bartek - Commits
- rCOMM834594e5184c: [keyserver] Check if a blob exists
Create a script that tries to download two blobs - one with existing hash and one without. Check if the result is correct.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/services/blob.js | ||
|---|---|---|
| 64 ↗ | (On Diff #33459) | Downloading entire blob sounds like quite expensive operation just to check for blob existence. Are we sure there are no other ways to achieve similar result with less cost? Or is it the case that everytime we check for blob existence wa actually want to have it downloaded if it exists? If both answers are "no" then it looks like blob service might be missing some API. |
| keyserver/src/services/blob.js | ||
|---|---|---|
| 64 ↗ | (On Diff #33459) | For invite links, blobs should be rather small - a string representing an object with an ID and a URL, so the cost of downloading the entire blob shouldn't be important. And almost every time we download an invite link blob, we would check what's inside it. |