[keyserver] Check if a blob exists
ClosedPublic
Actions

Authored by tomek on Nov 21 2023, 8:05 AM.

Details

Reviewers

kamil
marcin
bartek

Commits

rCOMM834594e5184c: [keyserver] Check if a blob exists

Summary

After fetching a blob, check if it exists, and return different result depending on the test.

Depends on D9942

Test Plan

Create a script that tries to download two blobs - one with existing hash and one without. Check if the result is correct.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Nov 21 2023, 8:05 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 21 2023, 8:05 AM

Harbormaster completed remote builds in B24307: Diff 33459.Nov 21 2023, 8:25 AM

tomek requested review of this revision.Nov 21 2023, 8:25 AM

tomek added a child revision: D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.Nov 21 2023, 8:26 AM

marcin added inline comments.Nov 22 2023, 6:52 AM

keyserver/src/services/blob.js
64 ↗	(On Diff #33459)	Downloading entire blob sounds like quite expensive operation just to check for blob existence. Are we sure there are no other ways to achieve similar result with less cost? Or is it the case that everytime we check for blob existence wa actually want to have it downloaded if it exists? If both answers are "no" then it looks like blob service might be missing some API.

tomek added inline comments.Nov 23 2023, 3:55 AM

keyserver/src/services/blob.js
64 ↗	(On Diff #33459)	For invite links, blobs should be rather small - a string representing an object with an ID and a URL, so the cost of downloading the entire blob shouldn't be important. And almost every time we download an invite link blob, we would check what's inside it.

marcin accepted this revision.Nov 23 2023, 6:54 AM

This revision is now accepted and ready to land.Nov 23 2023, 6:54 AM

Closed by commit rCOMM834594e5184c: [keyserver] Check if a blob exists (authored by tomek). · Explain WhyNov 24 2023, 4:51 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM834594e5184c: [keyserver] Check if a blob exists.

tomek added a child revision: D9960: [keyserver] Add a column to invite_links table with a blob holder.Nov 24 2023, 6:15 AM

tomek removed a child revision: D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.

tomek added a child revision: D9944: [keyserver] Block creating invite links for which an entry in Blob service already exists.Jan 31 2024, 8:35 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

blob.js

17 lines

Diff 33583

View Options

keyserver/src/services/blob.js

// @flow		// @flow

import * as React from 'react';		import * as React from 'react';

		import { messageID } from './message-utils.js';
import SearchIndex from './search-index.js';		import SearchIndex from './search-index.js';
import {		import {
userIsMember,		userIsMember,
threadMemberHasPermission,		threadMemberHasPermission,
getContainingThreadID,		getContainingThreadID,
} from './thread-utils.js';		} from './thread-utils.js';
import {		import {
useSearchMessages as useSearchMessagesAction,		useSearchMessages as useSearchMessagesAction,
searchMessagesActionTypes,		searchMessagesActionTypes,
} from '../actions/message-actions.js';		} from '../actions/message-actions.js';
import {		import {
searchUsers,		searchUsers,
searchUsersActionTypes,		searchUsersActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
import genesis from '../facts/genesis.js';		import genesis from '../facts/genesis.js';
import type {		import type {
ChatMessageInfoItem,		ChatMessageInfoItem,
MessageListData,		MessageListData,
ChatMessageItem,
} from '../selectors/chat-selectors.js';		} from '../selectors/chat-selectors.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';		import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import { isComposableMessageType } from '../types/message-types.js';
import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { MinimallyEncodedThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';		import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';		import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import { type ThreadInfo } from '../types/thread-types.js';		import { type ThreadInfo } from '../types/thread-types.js';
import type {		import type {
AccountUserInfo,		AccountUserInfo,
UserListItem,		UserListItem,
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Lines	function getPotentialMemberItems({
const blockedRelationshipsStatuses = new Set([		const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER,		userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER,		userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,		userRelationshipStatus.BOTH_BLOCKED,
]);		]);

let userResults = values(results);		let userResults = values(results);
if (text === '') {		if (text === '') {
userResults = userResults.filter(userInfo =>		userResults = userResults.filter(userInfo => {
containingThreadInfo		if (!containingThreadInfo) {
? userInfo.isMemberOfContainingThread &&		return userInfo.relationshipStatus === userRelationshipStatus.FRIEND;
!blockedRelationshipsStatuses.has(userInfo.relationshipStatus)		}
: userInfo?.relationshipStatus === userRelationshipStatus.FRIEND,		if (!userInfo.isMemberOfContainingThread) {
);		return false;
		}
		const { relationshipStatus } = userInfo;
		if (!relationshipStatus) {
		return true;
		}
		return !blockedRelationshipsStatuses.has(relationshipStatus);
		});
}		}

const nonFriends = [];		const nonFriends = [];
const blockedUsers = [];		const blockedUsers = [];
const friends = [];		const friends = [];
const containingThreadMembers = [];		const containingThreadMembers = [];
const parentThreadMembers = [];		const parentThreadMembers = [];

for (const userResult of userResults) {		for (const userResult of userResults) {
const relationshipStatus = userResult.relationshipStatus;		const { relationshipStatus } = userResult;
if (blockedRelationshipsStatuses.has(relationshipStatus)) {		if (
		relationshipStatus &&
		blockedRelationshipsStatuses.has(relationshipStatus)
		) {
blockedUsers.push(userResult);		blockedUsers.push(userResult);
} else if (userResult.isMemberOfParentThread) {		} else if (userResult.isMemberOfParentThread) {
parentThreadMembers.push(userResult);		parentThreadMembers.push(userResult);
} else if (userResult.isMemberOfContainingThread) {		} else if (userResult.isMemberOfContainingThread) {
containingThreadMembers.push(userResult);		containingThreadMembers.push(userResult);
} else if (relationshipStatus === userRelationshipStatus.FRIEND) {		} else if (relationshipStatus === userRelationshipStatus.FRIEND) {
friends.push(userResult);		friends.push(userResult);
} else {		} else {
Show All 11 Lines	return sortedResults.map(
({		({
isMemberOfContainingThread,		isMemberOfContainingThread,
isMemberOfParentThread,		isMemberOfParentThread,
relationshipStatus,		relationshipStatus,
...result		...result
}) => {		}) => {
let notice, alert;		let notice, alert;
const username = result.username;		const username = result.username;
if (blockedRelationshipsStatuses.has(relationshipStatus)) {		if (
		relationshipStatus &&
		blockedRelationshipsStatuses.has(relationshipStatus)
		) {
notice = 'user is blocked';		notice = 'user is blocked';
alert = {		alert = {
title: 'User is blocked',		title: 'User is blocked',
text:		text:
`Before you add ${username} to this chat, ` +		`Before you add ${username} to this chat, ` +
'you’ll need to unblock them. You can do this from the Block List ' +		'you’ll need to unblock them. You can do this from the Block List ' +
'in the Profile tab.',		'in the Profile tab.',
};		};
▲ Show 20 Lines • Show All 114 Lines • ▼ Show 20 Lines
function filterChatMessageInfosForSearch(		function filterChatMessageInfosForSearch(
chatMessageInfos: MessageListData,		chatMessageInfos: MessageListData,
translatedSearchResults: $ReadOnlyArray<MessageInfo>,		translatedSearchResults: $ReadOnlyArray<MessageInfo>,
): ?(ChatMessageInfoItem[]) {		): ?(ChatMessageInfoItem[]) {
if (!chatMessageInfos) {		if (!chatMessageInfos) {
return null;		return null;
}		}

const idSet = new Set(translatedSearchResults.map(item => item.id));		const idSet = new Set(translatedSearchResults.map(messageID));

const chatMessageInfoItems = chatMessageInfos.filter(
item =>
item.messageInfo &&
idSet.has(item.messageInfo.id) &&
isComposableMessageType(item.messageInfo.type),
);

const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageItem>();		const uniqueChatMessageInfoItemsMap = new Map<string, ChatMessageInfoItem>();
chatMessageInfoItems.forEach(		for (const item of chatMessageInfos) {
item =>		if (item.itemType !== 'message' \|\| item.messageInfoType !== 'composable') {
item.messageInfo &&		continue;
item.messageInfo.id &&		}
uniqueChatMessageInfoItemsMap.set(item.messageInfo.id, item),		const id = messageID(item.messageInfo);
);		if (idSet.has(id)) {
		uniqueChatMessageInfoItemsMap.set(id, item);
		}
		}

const sortedChatMessageInfoItems = [];		const sortedChatMessageInfoItems: ChatMessageInfoItem[] = [];
for (let i = 0; i < translatedSearchResults.length; i++) {		for (let i = 0; i < translatedSearchResults.length; i++) {
sortedChatMessageInfoItems.push(		const id = messageID(translatedSearchResults[i]);
uniqueChatMessageInfoItemsMap.get(translatedSearchResults[i].id),		const match = uniqueChatMessageInfoItemsMap.get(id);
);		if (match) {
		sortedChatMessageInfoItems.push(match);
}		}
		}
return sortedChatMessageInfoItems.filter(Boolean);		return sortedChatMessageInfoItems;
}		}

export {		export {
getPotentialMemberItems,		getPotentialMemberItems,
notFriendNotice,		notFriendNotice,
useSearchMessages,		useSearchMessages,
useSearchUsers,		useSearchUsers,
filterChatMessageInfosForSearch,		filterChatMessageInfosForSearch,
};		};

[keyserver] Check if a blob existsClosedPublicActions