Page MenuHomePhabricator
Differential D10205

[keyserver] Add a function that synchronizes keyserver's invite links with blobs
ClosedPublic
Actions

Authored by tomek on Dec 6 2023, 6:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 12:58 AM
Unknown Object (File)
Wed, Mar 19, 2:02 AM
Unknown Object (File)
Tue, Mar 18, 8:34 AM
Unknown Object (File)
Tue, Mar 18, 8:34 AM
Unknown Object (File)
Tue, Mar 18, 8:34 AM
Unknown Object (File)
Tue, Mar 18, 8:33 AM
Unknown Object (File)
Sun, Mar 16, 12:06 AM
Unknown Object (File)
Fri, Mar 7, 12:10 AM
View All 100 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
Commits
rCOMM1131d2bb421a: [keyserver] Add a function that synchronizes keyserver's invite links with blobs
Summary

In this script we try to create blobs for links where a holder is missing or a holder doesn't point to an existing blob. This function will be used in a migration and in a script that periodically synchronizes data.

Depends on D10150

Test Plan

Run the function as a script and check if it creates blobs for all the links that don't have them.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Dec 6 2023, 6:13 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2023, 6:13 AM
Harbormaster completed remote builds in B24822: Diff 34336.Dec 6 2023, 6:31 AM
tomek requested review of this revision.Dec 6 2023, 6:31 AM
tomek added a child revision: D10206: [keyserver] Set a job that synchronizes links with blobs.Dec 6 2023, 6:39 AM
ashoat added inline comments.Dec 6 2023, 7:43 AM
keyserver/src/creators/invite-link-creator.js
202 ↗(On Diff #34336)

This should not be an async function, since it does not use the await keyword. This causes an unnecessary step where we wrap a Promise in another Promise

rohan requested changes to this revision.Dec 12 2023, 6:32 AM

Just requesting changes for the inline comment so it goes back in your queue

This revision now requires changes to proceed.Dec 12 2023, 6:32 AM
tomek updated this revision to Diff 36525.Feb 1 2024, 7:16 AM
tomek marked an inline comment as done.

Rebase

tomek removed a reviewer: rohan.Feb 1 2024, 7:17 AM
Harbormaster completed remote builds in B26415: Diff 36525.Feb 1 2024, 7:34 AM
bartek accepted this revision.Feb 6 2024, 2:42 AM
This revision is now accepted and ready to land.Feb 6 2024, 2:42 AM
Closed by commit rCOMM1131d2bb421a: [keyserver] Add a function that synchronizes keyserver's invite links with blobs (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1131d2bb421a: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
16 lines
services/
2 lines
updaters/
11 lines
utils/
44 lines

Diff 37088

View Options

keyserver/src/creators/invite-link-creator.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

keyserver/src/services/blob.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

keyserver/src/updaters/link-updaters.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

keyserver/src/utils/synchronizeInviteLinksWithBlobs.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines