Paths

Table of Contentst

-
keyserver/src/services/
-
src/
-
services/
-
blob.js

Differential D9966

[keyserver] Add a function that deletes a blob
ClosedPublic
Actions

Authored by tomek on Nov 24 2023, 6:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 17, 7:43 PM

	Unknown Object (File)
	Mon, Mar 17, 7:19 PM

	Unknown Object (File)
	Mon, Mar 17, 9:22 AM

	Unknown Object (File)
	Mon, Mar 17, 9:01 AM

	Unknown Object (File)
	Fri, Mar 14, 3:47 AM

	Unknown Object (File)
	Fri, Mar 14, 3:31 AM

	Unknown Object (File)
	Fri, Mar 14, 3:31 AM

	Unknown Object (File)
	Tue, Mar 11, 7:37 AM

Subscribers

Details

Reviewers

michal
bartek
rohan

Commits

rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob

Summary

This function calls an endpoint of Blob service that deletes a blob.

Depends on D9944

Test Plan

Create a blob and delete it - check if a holder is deleted.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Nov 24 2023, 6:48 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 6:48 AM

Harbormaster completed remote builds in B24387: Diff 33586.Nov 24 2023, 7:08 AM

tomek requested review of this revision.Nov 24 2023, 7:08 AM

tomek added a child revision: D9968: [keyserver] Fetch invite link blob holder.Nov 24 2023, 8:14 AM

rohan accepted this revision.Nov 24 2023, 10:42 AM

This revision is now accepted and ready to land.Nov 24 2023, 10:42 AM

Use a param object instead of two args for hash and holder to avoid the confusion between them

Harbormaster completed remote builds in B24640: Diff 34052.Nov 30 2023, 7:11 AM

Destructure params inside function

Set instant flag

Harbormaster completed remote builds in B26336: Diff 36404.Jan 31 2024, 8:57 AM

Harbormaster completed remote builds in B26338: Diff 36406.Jan 31 2024, 9:05 AM

bartek accepted this revision.Feb 7 2024, 2:05 AM

bartek added inline comments.

keyserver/src/services/blob.js
103–105 ↗	(On Diff #36406)	Before landing, could you update this diff to use the function from D10908?

Use auth headers

keyserver/src/services/blob.js
103–105 ↗	(On Diff #36406)	Sure!

Harbormaster completed remote builds in B26649: Diff 36846.Feb 8 2024, 6:47 AM

Closed by commit rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7053a0f8c5be: [keyserver] Add a function that deletes a blob.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

22 lines

Diff 37080

keyserver/src/services/blob.js

This file was copied to services/backup/src/Reactors/client/blob/BlobPutClientReactor.cpp.

	#pragma once			#pragma once

	#include "ClientBidiReactorBase.h"
	#include "Constants.h"			#include "Constants.h"

	#include "../_generated/blob.grpc.pb.h"			#include "../_generated/blob.grpc.pb.h"
	#include "../_generated/blob.pb.h"			#include "../_generated/blob.pb.h"

				#include "ClientBidiReactorBase.h"

	#include <folly/MPMCQueue.h>			#include <folly/MPMCQueue.h>
	#include <grpcpp/grpcpp.h>			#include <grpcpp/grpcpp.h>

	#include <condition_variable>			#include <condition_variable>
	#include <iostream>
	#include <memory>			#include <memory>
	#include <string>			#include <string>

	namespace comm {			namespace comm {
	namespace network {			namespace network {
	namespace reactor {			namespace reactor {

	class BlobPutClientReactor			class BlobPutClientReactor
	Show All 22 Lines		public:
	void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);			void scheduleSendingDataChunk(std::unique_ptr<std::string> dataChunk);
	std::unique_ptr<grpc::Status> prepareRequest(			std::unique_ptr<grpc::Status> prepareRequest(
	blob::PutRequest &request,			blob::PutRequest &request,
	std::shared_ptr<blob::PutResponse> previousResponse) override;			std::shared_ptr<blob::PutResponse> previousResponse) override;
	void doneCallback() override;			void doneCallback() override;
	grpc::Status getStatus() const;			grpc::Status getStatus() const;
	};			};

	BlobPutClientReactor::BlobPutClientReactor(
	const std::string &holder,
	const std::string &hash,
	std::condition_variable *terminationNotifier)
	: holder(holder),
	hash(hash),
	dataChunks(folly::MPMCQueue<std::string>(100)),
	terminationNotifier(terminationNotifier) {
	}

	void BlobPutClientReactor::scheduleSendingDataChunk(
	std::unique_ptr<std::string> dataChunk) {
	if (!this->dataChunks.write(std::move(*dataChunk))) {
	throw std::runtime_error(
	"Error scheduling sending a data chunk to send to the blob service");
	}
	}

	std::unique_ptr<grpc::Status> BlobPutClientReactor::prepareRequest(
	blob::PutRequest &request,
	std::shared_ptr<blob::PutResponse> previousResponse) {
	if (this->state == State::SEND_HOLDER) {
	this->request.set_holder(this->holder);
	this->state = State::SEND_HASH;
	return nullptr;
	}
	if (this->state == State::SEND_HASH) {
	request.set_blobhash(this->hash);
	this->state = State::SEND_CHUNKS;
	return nullptr;
	}
	if (previousResponse->dataexists()) {
	return std::make_unique<grpc::Status>(grpc::Status::OK);
	}
	std::string dataChunk;
	this->dataChunks.blockingRead(dataChunk);
	if (dataChunk.empty()) {
	return std::make_unique<grpc::Status>(grpc::Status::OK);
	}
	request.set_datachunk(dataChunk);
	return nullptr;
	}

	void BlobPutClientReactor::doneCallback() {
	this->terminationNotifier->notify_one();
	}

	grpc::Status BlobPutClientReactor::getStatus() const {
	return this->status;
	}

	} // namespace reactor			} // namespace reactor
	} // namespace network			} // namespace network
	} // namespace comm			} // namespace comm