Paths

Table of Contentst

Differential D9944

[keyserver] Block creating invite links for which an entry in Blob service already exists
ClosedPublic
Actions

Authored by tomek on Nov 21 2023, 8:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 6:42 PM

	Unknown Object (File)
	Tue, Nov 12, 7:36 AM

	Unknown Object (File)
	Mon, Nov 11, 3:29 PM

	Unknown Object (File)
	Mon, Nov 11, 2:24 AM

	Unknown Object (File)
	Sun, Nov 10, 11:24 PM

	Unknown Object (File)
	Sun, Nov 10, 11:40 AM

	Unknown Object (File)
	Sun, Nov 10, 11:40 AM

	Unknown Object (File)
	Sun, Nov 10, 11:40 AM

Subscribers

Details

Reviewers

michal
bartek
rohan

Commits

rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service…

Summary

If a keyserver tries to create a link for which an entry exists, it means that a link was already created by some keyserver. Only one link can exist with a given name, so we have to block such an attempt.

Depends on D9943

Test Plan

Create a blob with invite_${secret} hash and check if it is impossible to create a link with the same secret. Also check if it is still possible to create other links.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Nov 21 2023, 8:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 21 2023, 8:26 AM

Harbormaster completed remote builds in B24308: Diff 33460.Nov 21 2023, 8:45 AM

tomek requested review of this revision.Nov 21 2023, 8:45 AM

rohan accepted this revision.Nov 21 2023, 11:29 AM

This revision is now accepted and ready to land.Nov 21 2023, 11:29 AM

tomek added a child revision: D9960: [keyserver] Add a column to invite_links table with a blob holder.Nov 23 2023, 7:28 AM

Use better error code

tomek removed a child revision: D9960: [keyserver] Add a column to invite_links table with a blob holder.Nov 24 2023, 6:15 AM

tomek edited parent revisions, added: D9960: [keyserver] Add a column to invite_links table with a blob holder; removed: D9943: [keyserver] Check if a blob exists.

Harbormaster completed remote builds in B24386: Diff 33584.Nov 24 2023, 6:32 AM

tomek added a child revision: D9966: [keyserver] Add a function that deletes a blob.Nov 24 2023, 6:48 AM

ashoat added inline comments.Nov 26 2023, 3:10 PM

keyserver/src/creators/invite-link-creator.js
152 ↗	(On Diff #33584)	This doesn't need to be an `async` function

Delete unnecessary async

Harbormaster completed remote builds in B26335: Diff 36403.Jan 31 2024, 8:55 AM

Closed by commit rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service… (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

invite-link-creator.js

29 lines

services/

6 lines

Diff 37079

keyserver/src/creators/invite-link-creator.js

Loading...

keyserver/src/services/blob.js

Loading...