Page MenuHomePhabricator
Differential D9944

[keyserver] Block creating invite links for which an entry in Blob service already exists
ClosedPublic
Actions

Authored by tomek on Nov 21 2023, 8:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 9:39 PM
Unknown Object (File)
Feb 5 2025, 7:27 AM
Unknown Object (File)
Jan 22 2025, 11:42 PM
Unknown Object (File)
Jan 22 2025, 11:42 PM
Unknown Object (File)
Jan 22 2025, 11:42 PM
Unknown Object (File)
Jan 22 2025, 11:42 PM
Unknown Object (File)
Jan 22 2025, 11:38 PM
Unknown Object (File)
Jan 22 2025, 10:58 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
rohan
Commits
rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service…
Summary

If a keyserver tries to create a link for which an entry exists, it means that a link was already created by some keyserver. Only one link can exist with a given name, so we have to block such an attempt.

Depends on D9943

Test Plan

Create a blob with invite_${secret} hash and check if it is impossible to create a link with the same secret. Also check if it is still possible to create other links.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Nov 21 2023, 8:26 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 21 2023, 8:26 AM
Harbormaster completed remote builds in B24308: Diff 33460.Nov 21 2023, 8:45 AM
tomek requested review of this revision.Nov 21 2023, 8:45 AM
rohan accepted this revision.Nov 21 2023, 11:29 AM
This revision is now accepted and ready to land.Nov 21 2023, 11:29 AM
tomek added a child revision: D9960: [keyserver] Add a column to invite_links table with a blob holder.Nov 23 2023, 7:28 AM
tomek updated this revision to Diff 33584.Nov 24 2023, 6:14 AM

Use better error code

tomek removed a child revision: D9960: [keyserver] Add a column to invite_links table with a blob holder.Nov 24 2023, 6:15 AM
tomek edited parent revisions, added: D9960: [keyserver] Add a column to invite_links table with a blob holder; removed: D9943: [keyserver] Check if a blob exists.
Harbormaster completed remote builds in B24386: Diff 33584.Nov 24 2023, 6:32 AM
tomek added a child revision: D9966: [keyserver] Add a function that deletes a blob.Nov 24 2023, 6:48 AM
ashoat added inline comments.Nov 26 2023, 3:10 PM
keyserver/src/creators/invite-link-creator.js
152 ↗(On Diff #33584)

This doesn't need to be an async function

tomek updated this revision to Diff 36403.Jan 31 2024, 8:35 AM
tomek added a parent revision: D9943: [keyserver] Check if a blob exists.

Delete unnecessary async

Harbormaster completed remote builds in B26335: Diff 36403.Jan 31 2024, 8:55 AM
Closed by commit rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service… (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM649591495a52: [keyserver] Block creating invite links for which an entry in Blob service….

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
29 lines
services/
6 lines

Diff 37079

View Options

keyserver/src/creators/invite-link-creator.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linesconst light = Object.freeze({
drawerItemLabelLevel0: '#0A0A0A', drawerItemLabelLevel0: '#0A0A0A',
drawerItemLabelLevel1: '#0A0A0A', drawerItemLabelLevel1: '#0A0A0A',
drawerItemLabelLevel2: '#1F1F1F', drawerItemLabelLevel2: '#1F1F1F',
drawerOpenCommunityBackground: '#F5F5F5', drawerOpenCommunityBackground: '#F5F5F5',
drawerBackground: '#FFFFFF', drawerBackground: '#FFFFFF',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#EBEBEB', subthreadsModalBackground: '#EBEBEB',
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: '#0A0A0A',
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: '#808080', blockQuoteBorder: '#808080',
codeBackground: '#0A0A0A', codeBackground: '#0A0A0A',
disabledButton: '#404040', disabledButton: '#404040',
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
drawerOpenCommunityBackground: '#191919', drawerOpenCommunityBackground: '#191919',
drawerBackground: '#1F1F1F', drawerBackground: '#1F1F1F',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#1F1F1F', subthreadsModalBackground: '#1F1F1F',
subthreadsModalSearch: '#FFFFFF04', subthreadsModalSearch: '#FFFFFF04',
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: '#404040', typeaheadTooltipBorder: '#404040',
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: '#CCCCCC',
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines
View Options

keyserver/src/services/blob.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linesconst light = Object.freeze({
drawerItemLabelLevel0: '#0A0A0A', drawerItemLabelLevel0: '#0A0A0A',
drawerItemLabelLevel1: '#0A0A0A', drawerItemLabelLevel1: '#0A0A0A',
drawerItemLabelLevel2: '#1F1F1F', drawerItemLabelLevel2: '#1F1F1F',
drawerOpenCommunityBackground: '#F5F5F5', drawerOpenCommunityBackground: '#F5F5F5',
drawerBackground: '#FFFFFF', drawerBackground: '#FFFFFF',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#EBEBEB', subthreadsModalBackground: '#EBEBEB',
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: '#0A0A0A',
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: '#808080', blockQuoteBorder: '#808080',
codeBackground: '#0A0A0A', codeBackground: '#0A0A0A',
disabledButton: '#404040', disabledButton: '#404040',
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
drawerOpenCommunityBackground: '#191919', drawerOpenCommunityBackground: '#191919',
drawerBackground: '#1F1F1F', drawerBackground: '#1F1F1F',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#1F1F1F', subthreadsModalBackground: '#1F1F1F',
subthreadsModalSearch: '#FFFFFF04', subthreadsModalSearch: '#FFFFFF04',
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: '#404040', typeaheadTooltipBorder: '#404040',
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: '#CCCCCC',
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines