Page MenuHomePhabricator

[keyserver] Create invite link blobs in a migration
ClosedPublic

Authored by tomek on Feb 14 2024, 7:05 AM.
Tags
None
Referenced Files
F3351247: D11076.diff
Sat, Nov 23, 12:39 AM
Unknown Object (File)
Tue, Oct 29, 9:18 AM
Unknown Object (File)
Oct 4 2024, 4:21 AM
Unknown Object (File)
Oct 4 2024, 4:21 AM
Unknown Object (File)
Oct 4 2024, 4:20 AM
Unknown Object (File)
Oct 4 2024, 4:20 AM
Unknown Object (File)
Sep 10 2024, 5:05 PM
Unknown Object (File)
Sep 5 2024, 11:41 AM
Subscribers

Details

Summary

In D10206 we're running this in cron, but we also should do that in a migration - this isn't strictly necessary because cron would update it later, but it is better to do that immediately.

Additionally, the function was modified so that the migration / job doesn't fail in environments where we aren't authenticated to Identity service.

Depends on D11051

Test Plan

Run the keyserver and check if the migration creates holders in invite_links table.
Kill the keyserver, delete auth metadata, decrement db version, delete the holder and update invite link secret. Then run the keyserver - the migration should succeed by printing an error message - the holder shouldn't be created.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Feb 14 2024, 7:21 AM
This revision is now accepted and ready to land.Feb 14 2024, 7:46 AM
keyserver/src/utils/synchronizeInviteLinksWithBlobs.js
44

Will monitor for this string next time I deploy the keyserver