Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMM62ffb3166fda: [lib] Move actualizedCalendarQuery into keyserver store

Summary

Move the filed to the store - this change means that we keep a separate value for each keyserver. This value includes only the filters from that keyserver.

https://linear.app/comm/issue/ENG-6901/move-actualizedcalendarquery-into-keyserver-store

Depends on D11135

Test Plan

Check if a migration succeeds on native and web - inspect Redux store after the migration and check if there are no inconsistencies reported.
Open a calendar, modify date range and check if the value is correctly updated in keyserver store.
Close and reopen the native app - there should be no inconsistency warning.
Log out and in, modify the dates - the store should be updated correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 22 2024, 5:41 AM

tomek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 22 2024, 5:41 AM

tomek added 2 blocking reviewer(s): inka, kamil.Feb 22 2024, 5:51 AM

Fix some bugs and update test plan

Harbormaster failed remote builds in B27059: Diff 37437!Feb 22 2024, 5:57 AM

tomek published this revision for review.Feb 22 2024, 6:08 AM

tomek added inline comments.

lib/reducers/keyserver-reducer.js
178–183 ↗	(On Diff #37438)	In `calendar-query-reducer` we were filtering out the filters ...state, filters: removeKeyserverThreadIDsFromFilterList(state.filters, [ action.payload.keyserverID, ]), but here we know that all the thread filters are from this keyserver
242–245 ↗	(On Diff #37438)	In `calendar-query-reducer` we weren't handling `keyserverAuthActionTypes.success`, but I think it makes sense to handle it

Harbormaster failed remote builds in B27060: Diff 37438!Feb 22 2024, 6:12 AM

tomek edited the test plan for this revision. (Show Details)Feb 22 2024, 6:12 AM

Fix tests by introducing a jest mock

Harbormaster completed remote builds in B27063: Diff 37441.Feb 22 2024, 6:50 AM

You also need to remove actualizedCalendarQuery from states on web and native. And then from default states.

inka added inline comments.Feb 22 2024, 7:11 AM

web/redux/action-types.js
95–99 ↗	(On Diff #37441)	Where is this being handled now?

inka requested changes to this revision.Feb 22 2024, 7:14 AM

This revision now requires changes to proceed.Feb 22 2024, 7:14 AM

Update native state type
Use defaultCalendarQuery function in the default keyserver store
Handle actualizedCalendarQuery from an initial state in the reducer

web/redux/action-types.js
95–99 ↗	(On Diff #37441)	Good question! We should keep this field in the initial state and handle it in the reducer.

tomek planned changes to this revision.Feb 23 2024, 5:51 AM

Fix top-level default keyserver info - the app was crashing because config isn't registered when executing
top-level

Harbormaster completed remote builds in B27108: Diff 37516.Feb 23 2024, 6:24 AM

Harbormaster completed remote builds in B27110: Diff 37518.Feb 23 2024, 6:33 AM

inka accepted this revision.Feb 23 2024, 7:46 AM

kamil accepted this revision.Feb 26 2024, 2:32 AM

kamil added inline comments.

web/redux/persist.js
360 ↗	(On Diff #37518)	I think you should bump the version (both here and on native) and test it once more

This revision is now accepted and ready to land.Feb 26 2024, 2:32 AM

Tested native migration and deleted web migration - we aren't persisting actualizedCalendarQuery on web
and we don't need to migrate it - default state contains a new value.

Harbormaster failed remote builds in B27177: Diff 37607!Feb 26 2024, 6:30 AM

tomek added a child revision: D11176: [lib] Add keyserverID param to getClientResponsesSelector.Feb 26 2024, 6:37 AM

Harbormaster completed remote builds in B27177: Diff 37607.Feb 26 2024, 3:48 PM

Rebase

Harbormaster completed remote builds in B27196: Diff 37642.Feb 27 2024, 1:34 AM

Closed by commit rCOMM62ffb3166fda: [lib] Move actualizedCalendarQuery into keyserver store (authored by tomek). · Explain WhyFeb 27 2024, 1:41 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM62ffb3166fda: [lib] Move actualizedCalendarQuery into keyserver store.

[lib] Move actualizedCalendarQuery into keyserver store
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 37644

lib/reducers/calendar-query-reducer.js

lib/reducers/keyserver-reducer.js

lib/reducers/keyserver-reducer.test.js

lib/reducers/master-reducer.js

lib/socket/calendar-query-handler.react.js

lib/types/keyserver-types.js

lib/types/redux-types.js

lib/utils/mocks/config.js

lib/utils/reducers-utils.test.js

native/redux/default-state.js

native/redux/persist.js

native/redux/state-types.js

web/database/queries/keyservers-queries.test.js

web/redux/default-state.js

web/redux/redux-setup.js

[lib] Move actualizedCalendarQuery into keyserver storeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37644

lib/reducers/calendar-query-reducer.js

lib/reducers/keyserver-reducer.js

lib/reducers/keyserver-reducer.test.js

lib/reducers/master-reducer.js

lib/socket/calendar-query-handler.react.js

lib/types/keyserver-types.js

lib/types/redux-types.js

lib/utils/__mocks__/config.js

lib/utils/reducers-utils.test.js

native/redux/default-state.js

native/redux/persist.js

native/redux/state-types.js

web/database/queries/keyservers-queries.test.js

web/redux/default-state.js

web/redux/redux-setup.js

[lib] Move actualizedCalendarQuery into keyserver store
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js