[lib] Check keyserver connection in request-response-handler
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 6:27 AM.

Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMM8cea21c8a21e: [lib] Check keyserver connection in request-response-handler

Summary

getClientResponses is already keyserver-specific and aware of the keyserver id, so the only needed change for this handler is to select a proper connection status.

https://linear.app/comm/issue/ENG-5780/update-requestresponsehandler

Depends on D11184

Test Plan

Add some console logs checking if we select the connection.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 27 2024, 6:27 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2024, 6:28 AM

Harbormaster completed remote builds in B27205: Diff 37654.Feb 27 2024, 6:42 AM

tomek requested review of this revision.Feb 27 2024, 6:42 AM

tomek added a child revision: D11186: [lib] Move report handler from a socket.Feb 27 2024, 7:50 AM

michal accepted this revision.Feb 28 2024, 6:18 AM

This revision is now accepted and ready to land.Feb 28 2024, 6:18 AM

Closed by commit rCOMM8cea21c8a21e: [lib] Check keyserver connection in request-response-handler (authored by tomek). · Explain WhyFeb 29 2024, 7:42 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM8cea21c8a21e: [lib] Check keyserver connection in request-response-handler.

Revision Contents
Changeset List

Path

Size

lib/

socket/

request-response-handler.react.js

5 lines

Diff 37706

View Options

lib/socket/request-response-handler.react.js

[lib] Check keyserver connection in request-response-handlerClosedPublicActions