[lib] Move report handler from a socket
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 7:50 AM.

Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMM1f2a63c77728: [lib] Move report handler from a socket

Summary

This component isn't using socket at all and isn't specific to a keyserver. Moreover, rendering a couple of handlers could result in some reports delivered multiple times.

https://linear.app/comm/issue/ENG-7013/update-reporthandler

Depends on D11185

Test Plan

Generate an inconsistency and check if reports are generated on web and native by adding some console logs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 27 2024, 7:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2024, 7:50 AM

tomek added a child revision: D11187: [lib] Render a socket for each keyserver.Feb 27 2024, 7:56 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2024, 9:01 AM

Harbormaster failed remote builds in B27206: Diff 37655!

Harbormaster completed remote builds in B27206: Diff 37655.Feb 27 2024, 9:08 AM

tomek requested review of this revision.Feb 27 2024, 9:08 AM

michal accepted this revision.Feb 28 2024, 6:10 AM

This revision is now accepted and ready to land.Feb 28 2024, 6:10 AM

tomek edited the test plan for this revision. (Show Details)Feb 29 2024, 7:38 AM

Closed by commit rCOMM1f2a63c77728: [lib] Move report handler from a socket (authored by tomek). · Explain WhyFeb 29 2024, 7:42 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1f2a63c77728: [lib] Move report handler from a socket.

Revision Contents
Changeset List

Path

Size

lib/

	components/
	socket/

report-handler.react.js

socket/

report-handler.react.js

socket.react.js

3 lines

native/

components/

report-handler.react.js

21 lines

root.react.js

2 lines

socket.react.js

10 lines

web/

root.js

2 lines

socket.react.js

1 line

Diff 37707

View Options

lib/components/report-handler.react.js

	provider "sops" {}

	data "sops_file" "keyserver_secrets_json" {
	source_file = "keyserver_secrets.json"
	}

	locals {
	secrets = jsondecode(data.sops_file.keyserver_secrets_json.raw)
	}

	provider "aws" {			provider "aws" {
	region = "us-east-2"			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}

View Options

lib/socket/report-handler.react.js

	provider "sops" {}

	data "sops_file" "keyserver_secrets_json" {
	source_file = "keyserver_secrets.json"
	}

	locals {
	secrets = jsondecode(data.sops_file.keyserver_secrets_json.raw)
	}

	provider "aws" {			provider "aws" {
	region = "us-east-2"			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}

View Options

lib/socket/socket.react.js

	provider "sops" {}

	data "sops_file" "keyserver_secrets_json" {
	source_file = "keyserver_secrets.json"
	}

	locals {
	secrets = jsondecode(data.sops_file.keyserver_secrets_json.raw)
	}

	provider "aws" {			provider "aws" {
	region = "us-east-2"			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}

View Options

native/components/report-handler.react.js

	provider "sops" {}

	data "sops_file" "keyserver_secrets_json" {
	source_file = "keyserver_secrets.json"
	}

	locals {
	secrets = jsondecode(data.sops_file.keyserver_secrets_json.raw)
	}

	provider "aws" {			provider "aws" {
	region = "us-east-2"			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}