Page MenuHomePhabricator
Differential D11182

[lib] Add keyserverID to processServerRequestsActionType
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 2:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 5:46 AM
Unknown Object (File)
Feb 16 2025, 12:18 AM
Unknown Object (File)
Feb 16 2025, 12:18 AM
Unknown Object (File)
Feb 16 2025, 12:17 AM
Unknown Object (File)
Feb 16 2025, 12:17 AM
Unknown Object (File)
Jan 31 2025, 7:34 PM
Unknown Object (File)
Jan 13 2025, 8:39 AM
Unknown Object (File)
Jan 5 2025, 4:22 AM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
michal
atul
inka
kamil
Commits
rCOMM80c75e317126: [lib] Add keyserverID to processServerRequestsActionType
Summary

This is needed to correctly compute store inconsistencies - we should filter only the entities from one keyserver.

https://linear.app/comm/issue/ENG-5780/update-requestresponsehandler

Depends on D11181

Test Plan

Increase session check frequency and add a console.log in entries reducer to verify that processServerRequestsActionType payload contains keyserverID.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
socket/
2 lines
1 line
types/
1 line

Diff 37703

View Options

lib/socket/request-response-handler.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getAvatarForUser, getAvatarForUser,
useResolvedAvatar, useResolvedAvatar,
} from 'lib/shared/avatar-utils.js'; } from 'lib/shared/avatar-utils.js';
import type { AvatarSize } from 'lib/types/avatar-types.js'; import type { AvatarSize } from 'lib/types/avatar-types.js';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import Avatar from './avatar.react.js'; import Avatar from './avatar.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
type Props = { type Props = {
+userID: ?string, +userID: ?string,
+size: AvatarSize, +size: AvatarSize,
+showSpinner?: boolean, +showSpinner?: boolean,
}; };
function UserAvatar(props: Props): React.Node { function UserAvatar(props: Props): React.Node {
const { userID, size, showSpinner } = props; const { userID, size, showSpinner } = props;
const userInfo = useSelector(state => const currentUserFID = useCurrentUserFID();
userID ? state.userStore.userInfos[userID] : null, const userAvatarInfo = useSelector(state => {
); if (!userID) {
const avatarInfo = getAvatarForUser(userInfo); return null;
} else if (userID === state.currentUserInfo?.id) {
return {
...state.currentUserInfo,
farcasterID: currentUserFID,
};
} else {
return {
...state.userStore.userInfos[userID],
farcasterID: state.auxUserStore.auxUserInfos[userID]?.fid,
};
}
});
const avatar = getAvatarForUser(userAvatarInfo);
const resolvedUserAvatar = useResolvedAvatar(avatarInfo, userInfo); const resolvedUserAvatar = useResolvedAvatar(avatar, userAvatarInfo);
return ( return (
<Avatar <Avatar
size={size} size={size}
avatarInfo={resolvedUserAvatar} avatarInfo={resolvedUserAvatar}
showSpinner={showSpinner} showSpinner={showSpinner}
/> />
); );
} }
export default UserAvatar; export default UserAvatar;
View Options

lib/socket/socket.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getAvatarForUser, getAvatarForUser,
useResolvedAvatar, useResolvedAvatar,
} from 'lib/shared/avatar-utils.js'; } from 'lib/shared/avatar-utils.js';
import type { AvatarSize } from 'lib/types/avatar-types.js'; import type { AvatarSize } from 'lib/types/avatar-types.js';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import Avatar from './avatar.react.js'; import Avatar from './avatar.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
type Props = { type Props = {
+userID: ?string, +userID: ?string,
+size: AvatarSize, +size: AvatarSize,
+showSpinner?: boolean, +showSpinner?: boolean,
}; };
function UserAvatar(props: Props): React.Node { function UserAvatar(props: Props): React.Node {
const { userID, size, showSpinner } = props; const { userID, size, showSpinner } = props;
const userInfo = useSelector(state => const currentUserFID = useCurrentUserFID();
userID ? state.userStore.userInfos[userID] : null, const userAvatarInfo = useSelector(state => {
); if (!userID) {
const avatarInfo = getAvatarForUser(userInfo); return null;
} else if (userID === state.currentUserInfo?.id) {
return {
...state.currentUserInfo,
farcasterID: currentUserFID,
};
} else {
return {
...state.userStore.userInfos[userID],
farcasterID: state.auxUserStore.auxUserInfos[userID]?.fid,
};
}
});
const avatar = getAvatarForUser(userAvatarInfo);
const resolvedUserAvatar = useResolvedAvatar(avatarInfo, userInfo); const resolvedUserAvatar = useResolvedAvatar(avatar, userAvatarInfo);
return ( return (
<Avatar <Avatar
size={size} size={size}
avatarInfo={resolvedUserAvatar} avatarInfo={resolvedUserAvatar}
showSpinner={showSpinner} showSpinner={showSpinner}
/> />
); );
} }
export default UserAvatar; export default UserAvatar;
View Options

lib/types/request-types.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getAvatarForUser, getAvatarForUser,
useResolvedAvatar, useResolvedAvatar,
} from 'lib/shared/avatar-utils.js'; } from 'lib/shared/avatar-utils.js';
import type { AvatarSize } from 'lib/types/avatar-types.js'; import type { AvatarSize } from 'lib/types/avatar-types.js';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import Avatar from './avatar.react.js'; import Avatar from './avatar.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
type Props = { type Props = {
+userID: ?string, +userID: ?string,
+size: AvatarSize, +size: AvatarSize,
+showSpinner?: boolean, +showSpinner?: boolean,
}; };
function UserAvatar(props: Props): React.Node { function UserAvatar(props: Props): React.Node {
const { userID, size, showSpinner } = props; const { userID, size, showSpinner } = props;
const userInfo = useSelector(state => const currentUserFID = useCurrentUserFID();
userID ? state.userStore.userInfos[userID] : null, const userAvatarInfo = useSelector(state => {
); if (!userID) {
const avatarInfo = getAvatarForUser(userInfo); return null;
} else if (userID === state.currentUserInfo?.id) {
return {
...state.currentUserInfo,
farcasterID: currentUserFID,
};
} else {
return {
...state.userStore.userInfos[userID],
farcasterID: state.auxUserStore.auxUserInfos[userID]?.fid,
};
}
});
const avatar = getAvatarForUser(userAvatarInfo);
const resolvedUserAvatar = useResolvedAvatar(avatarInfo, userInfo); const resolvedUserAvatar = useResolvedAvatar(avatar, userAvatarInfo);
return ( return (
<Avatar <Avatar
size={size} size={size}
avatarInfo={resolvedUserAvatar} avatarInfo={resolvedUserAvatar}
showSpinner={showSpinner} showSpinner={showSpinner}
/> />
); );
} }
export default UserAvatar; export default UserAvatar;