Paths

Table of Contentst

Differential D11181

[lib] Use keyserverID when generating initial message using socket
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 1:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 13, 1:58 AM

	Unknown Object (File)
	Fri, Jun 7, 6:55 PM

	Unknown Object (File)
	Fri, Jun 7, 6:55 PM

	Unknown Object (File)
	Fri, Jun 7, 6:55 PM

	Unknown Object (File)
	Fri, Jun 7, 3:11 PM

	Unknown Object (File)
	May 7 2024, 5:34 PM

	Unknown Object (File)
	Apr 26 2024, 1:28 AM

	Unknown Object (File)
	Apr 15 2024, 11:48 PM

View All 23 Files

Subscribers

Details

Reviewers

michal
atul
marcin
kamil

Commits

rCOMM6123d12b7b83: [lib] Use keyserverID when generating initial message using socket

Summary

Use the actual keyserverID.

https://linear.app/comm/issue/ENG-6523/use-keyserver-id-when-generating-a-response-to

Depends on D11177

Test Plan

Delete a session on keyserver, restart the native client and verify that the code handling INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE was called. Send a message from web client and verify that a notification was delivered without a warning about missing session.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 27 2024, 1:38 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2024, 1:38 AM

Harbormaster completed remote builds in B27197: Diff 37643.Feb 27 2024, 1:53 AM

tomek requested review of this revision.Feb 27 2024, 1:53 AM

tomek added a child revision: D11182: [lib] Add keyserverID to processServerRequestsActionType.Feb 27 2024, 2:12 AM

atul accepted this revision.Feb 27 2024, 1:16 PM

This revision is now accepted and ready to land.Feb 27 2024, 1:16 PM

Closed by commit rCOMM6123d12b7b83: [lib] Use keyserverID when generating initial message using socket (authored by tomek). · Explain WhyFeb 29 2024, 7:42 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM6123d12b7b83: [lib] Use keyserverID when generating initial message using socket.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

6 lines

Diff 37702

lib/selectors/socket-selectors.js

Loading...