[lib] Make api-request-handler keyserver-specific
ClosedPublic
Actions

Authored by tomek on Feb 15 2024, 4:13 AM.

Details

Reviewers

inka
kamil
michal
atul

Commits

rCOMMf5e11bdfcd79: [lib] Make api-request-handler keyserver-specific

Summary

Select a connection status from the given keyserver.
Modify socketAPIHandlers to be a map from keyserver to SocketAPIHandler.

https://linear.app/comm/issue/ENG-5778/update-apirequesthandler

Test Plan

Added console.logs in fetchResponse to check if it is called and if a request is matched with response. Focused a thread and checked if proper request and response were generated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 15 2024, 4:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 15 2024, 4:13 AM

tomek edited the summary of this revision. (Show Details)Feb 15 2024, 4:14 AM

Harbormaster completed remote builds in B26915: Diff 37237.Feb 15 2024, 4:27 AM

tomek requested review of this revision.Feb 15 2024, 4:27 AM

ashoat added inline comments.Feb 15 2024, 5:58 AM

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js
446–452 ↗	(On Diff #37237)	I guess this works, but I wonder if it would be more idiomatic to move this to the provider... `socketAPIHandlers` could be a ref, and `registerActiveSocket` could be a utility exposed via the context