removed some unnecssary checks

double checked android rendering

Discovered bug with the avatar generating new random avatar when creating a new chat or sub channel will update this when resolved

address tomeks comments

rebase after merge

rebase after merge

use new avatar types introduced by @atul

rebase after merge

use new avatar types introduced by @atul

rebase before landing

rebase before landing

rebase before landing

rebase before landing

rebase before landing

implemented atuls quick suggestion

fix gates

added avatar client feature gate to fetcher

improvements

Still need to fix chat bubble poking out (will timebox for 1-2hrs)

looks good thanks for making the unit tests

address comments

Sequencing this diff towards the end of the diff stack (need to put up a few more diffs up first) but will update the relational revisions when I have a better idea

Changed the stack order so that this diff comes after D7099, so that we aren't blocked on this diff for landing the avatars work once D7099 (feature flag work) is accepted. I tested on my local stack each diff when changing the order and nothing was broken

rebase after changing up diff stack order

rebase after switching up diff stack order

rebase after switching up diff stack order

rebase after switching up diff stack order

rebase

In D7067#210469, @ashoat wrote:

I'm thinking basically:

1. In current master, figure out what % of total screen width a chat bubble can take
2. Subtract the space necessary for the avatar from the total screen width
3. Keep the % from 1 the same after adjusting for 2

Does that make sense?

Ah nice, disregard my comment about the if condition in the previous diff.

Also after reading D7018 disregard my comment above about the if statement

Left a few comments inline. Should we also add a condition to the if condition in composed-message to render the inline engagement?

accepting with one question inline

Nice thanks for addressing my comments and adding shimUnsupportedMessageInfo and unshimMessageInfo . Just make sure before you land that you address @ashoat's comment above and please make note somewhere or create a linear task to set the correct code version when we launch this feature

In D7067#210294, @ashoat wrote:

Did you decrease both chat bubbles' sizes by avatarOffset? That means we're subtracting 2 * avatarOffset when we only need space for avatarOffset, right? Can you please adjust it appropriately to maintain previous proportions?

make width consistent for all composed messages

Reduce the width for ALL composed messages bubbles to maintain consistency on the width

Offline asked @ginsu if we should maintain consistency on the width of chat message bubbles for viewer vs. non-viewer, he's going to check with Ted

only reduce the width of non viewer-composed messages as well as all multimedia messages

Open to decreasing media width