Page MenuHomePhabricator
Differential D10139

[native][web] Remove `LegacyThreadInfo` where possible after updating `useRoleUserSurfacedPermissions`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 8:58 AM.
Tags
None
Referenced Files
F5314049: D10139.id.diff
Tue, Apr 8, 3:42 PM
F5298734: D10139.diff
Mon, Apr 7, 11:45 PM
Unknown Object (File)
Wed, Apr 2, 7:41 PM
Unknown Object (File)
Wed, Apr 2, 3:52 AM
Unknown Object (File)
Thu, Mar 20, 9:56 PM
Unknown Object (File)
Wed, Mar 19, 11:06 PM
Unknown Object (File)
Fri, Mar 14, 1:23 PM
Unknown Object (File)
Mar 5 2025, 5:03 PM
View All 79 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMda210b7b0729: [native][web] Remove `LegacyThreadInfo` where possible after updating…
Summary

Simple LegacyThreadInfo removals after useRoleUserSurfacedPermissions update to support MinimallyEncodedThreadInfo.

This brings us to 79 usages of LegacyThreadInfo down from 700+.

Next diffs will involve ripping LegacyThreadInfo out of

  • native/chat
  • lib/selectors
  • etc

Depends on D10138

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 34157

View Options

native/calendar/calendar.react.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines
View Options

native/components/thread-list.react.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines
View Options

native/keyboard/keyboard-input-host.react.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines
View Options

native/roles/community-roles-screen.react.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines
View Options

web/roles/community-roles-modal.react.js

Loading...
View Options

web/roles/role-actions-menu.react.js

Loading...
View Options

web/roles/role-panel-entry.react.js

Loading...