Page MenuHomePhabricator
Differential D10168

[native][web] Cast InputState / BaseInputState when returning from selectors
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:14 PM.
Tags
None
Referenced Files
F3383498: D10168.diff
Thu, Nov 28, 4:07 PM
Unknown Object (File)
Mon, Nov 25, 2:49 AM
Unknown Object (File)
Mon, Nov 25, 2:33 AM
Unknown Object (File)
Mon, Nov 25, 2:21 AM
Unknown Object (File)
Tue, Nov 19, 11:47 PM
Unknown Object (File)
Fri, Nov 8, 4:01 PM
Unknown Object (File)
Thu, Nov 7, 6:00 PM
Unknown Object (File)
Oct 16 2024, 5:54 PM
View All 65 Files
Subscribers
atul
tomek

Details

Reviewers
atul
Commits
rCOMM96798907caca: [native][web] Cast InputState / BaseInputState when returning from selectors
Summary

While working on the unused-promise Flow lint (in particular, D10162) I noticed that Flow was failing to typecheck the return value of these selectors.

Adding this cast fixed the issue, and things appear to be typechecked correctly now.

(@atul, this was the change that previously caused minimallyEncoded type errors for me, but no longer does after rebasing.)

Depends on D10167

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:14 PM
ashoat added a child revision: D10169: [native] Add some awaits in ChatInputBar.onSend.Dec 4 2023, 1:14 PM
ashoat edited the summary of this revision. (Show Details)Dec 4 2023, 1:24 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:39 PM
Harbormaster failed remote builds in B24747: Diff 34210!
ashoat updated this revision to Diff 34227.Dec 4 2023, 4:10 PM

ESLint

ashoat published this revision for review.Dec 4 2023, 6:26 PM

Not sure what's going on with CI

Harbormaster completed remote builds in B24764: Diff 34227.Dec 4 2023, 6:35 PM
atul accepted this revision.Dec 5 2023, 7:41 AM
This revision is now accepted and ready to land.Dec 5 2023, 7:41 AM
Closed by commit rCOMM96798907caca: [native][web] Cast InputState / BaseInputState when returning from selectors (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM96798907caca: [native][web] Cast InputState / BaseInputState when returning from selectors.

Revision Contents
Changeset List

PathSize
native/
input/
37 lines
web/
input/
4 lines

Diff 34227

View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...