[web] rename message results modal to be pinned messages modal
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:17 AM.

Details

Reviewers

atul
rohan
kamil

Commits

rCOMMa36bb67e51fa: [web] rename message results modal to be pinned messages modal

Summary

Spoke to @rohan about this, but initially there was some intention to make the message results modal the same modal for message pinning and message search that never panned out. To make things less confusing for other devs decided to rename this to PinnedMessagesModal

Depends on D10344

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 12:17 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:17 AM

ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:19 AM

ginsu added reviewers: atul, rohan, kamil.

ginsu added a parent revision: D10344: [web] cleanup message results modal.

ginsu added a child revision: D10346: [lib/web/native] rename toggle pin utils to be message pinning utils.Dec 15 2023, 12:23 AM

Harbormaster completed remote builds in B25102: Diff 34689.Dec 15 2023, 12:40 AM

ginsu requested review of this revision.Dec 15 2023, 12:40 AM

Thanks for doing this! I know you're working primarily on web, but while you're doing this could you also rename the MessageResultsScreen for native for the same thing? Let me know if it's a little complicated / it'll delay your work and I can do it later myself as well!

This revision is now accepted and ready to land.Dec 15 2023, 8:11 AM

Thanks for doing this! I know you're working primarily on web, but while you're doing this could you also rename the MessageResultsScreen for native for the same thing? Let me know if it's a little complicated / it'll delay your work and I can do it later myself as well!

I want to land this diff rn since some of the diffs for the message list will depend on this, but created a Linear task to track rohan's request
https://linear.app/comm/issue/ENG-6356/rename-messageresultsscreen-on-native-to-be-pinned-messages-screen

ginsu removed a parent revision: D10344: [web] cleanup message results modal.Jan 4 2024, 6:29 PM