Page MenuHomePhabricator
Differential D10358

[web] introduce useNavigationSidebarTooltip hook
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:44 PM.
Tags
None
Referenced Files
F1798514: D10358.diff
Mon, May 20, 1:50 AM
F1798506: D10358.diff
Mon, May 20, 1:44 AM
Unknown Object (File)
Feb 20 2024, 8:13 AM
Unknown Object (File)
Feb 20 2024, 2:48 AM
Unknown Object (File)
Feb 19 2024, 10:55 PM
Unknown Object (File)
Feb 19 2024, 6:43 PM
Unknown Object (File)
Feb 18 2024, 11:38 AM
Unknown Object (File)
Feb 18 2024, 9:20 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMa9c88c6930e8: [web] introduce useNavigationSidebarTooltip hook
Summary

This diff introduces the useNavigationSidebarTooltip hook. Every tooltip has a hook similar to this that will calculate the size of the tooltip, create the tooltip instance and return the onMouseEnter + onMouseLeave callbacks that we will pass to the elements in the navigation sidebar that have tooltips. For context on how we use these hooks to build tooltips here are the useReactionSidebarTooltip hook and useMessageTooltip.

https://github.com/CommE2E/comm/blob/master/web/utils/tooltip-action-utils.js#L446

https://github.com/CommE2E/comm/blob/master/web/utils/tooltip-action-utils.js#L391

Part of https://linear.app/comm/issue/ENG-5948/hovering-over-every-clickable-element-in-this-sidebar-will-have-a

Depends on D10357

Test Plan

Please see demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 15 2023, 12:44 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:44 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:50 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu edited the test plan for this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:52 PM
ginsu added a parent revision: D10357: [web] introduce calculateNavigationSidebarTooltipSize.
ginsu added a child revision: D10359: [web] introduce community list item component.Dec 15 2023, 12:56 PM
ginsu added a child revision: D10360: [web] introduce community list.Dec 15 2023, 1:02 PM
ginsu removed a child revision: D10360: [web] introduce community list.Dec 15 2023, 1:10 PM
Harbormaster completed remote builds in B25135: Diff 34745.Dec 15 2023, 1:25 PM
ginsu requested review of this revision.Dec 15 2023, 1:25 PM
atul accepted this revision.Dec 20 2023, 9:58 PM
atul added inline comments.
web/utils/tooltip-action-utils.js
493–495

Looks like we have this same check in useMessageTooltip and useReactionTooltip, so assuming it's fine.

This revision is now accepted and ready to land.Dec 20 2023, 9:58 PM
ginsu updated this revision to Diff 34931.Dec 21 2023, 2:45 PM

rebase before landing

Harbormaster completed remote builds in B25294: Diff 34931.Dec 21 2023, 3:25 PM
Closed by commit rCOMMa9c88c6930e8: [web] introduce useNavigationSidebarTooltip hook (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa9c88c6930e8: [web] introduce useNavigationSidebarTooltip hook.

Revision Contents
Changeset List

PathSize
web/
utils/
38 lines

Diff 34745

View Options

web/utils/tooltip-action-utils.js

Loading...