[web] cleanup and better organize code for tooltips
ClosedPublic
Actions

Authored by ginsu on Dec 27 2023, 9:59 PM.

Details

Reviewers

atul
kamil
rohan

Commits

rCOMM2d8266808317: [web] cleanup and better organize code for tooltips

Summary

Move diff. As I have been working with the tooltip code recenlty I've noted that the tooltip code is all over the place and is not organized well. I wanted to take a moment to "clean up" the neighborhood and put all the tooltip code into a singular place

Depends on D10473

Test Plan

flow and confirmed that all the tooltips (message action, reaction, and label) had no regressions

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Dec 27 2023, 9:59 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 27 2023, 9:59 PM

update

ginsu edited the summary of this revision. (Show Details)Dec 27 2023, 10:02 PM

ginsu added reviewers: atul, kamil, rohan.

ginsu added a parent revision: D10473: [web] rename navigation sidebar tooltip to label tooltip.

Harbormaster completed remote builds in B25362: Diff 35041.Dec 27 2023, 10:19 PM

Harbormaster completed remote builds in B25363: Diff 35042.Dec 27 2023, 10:32 PM

ginsu requested review of this revision.Dec 27 2023, 10:32 PM

Looks good, thanks for tidying things up.

Nit: Would've been helpful if there was overview of changes in Summary so I had a more concrete idea of what to expect. Also not a huge deal, but there's a "move" in addition to all of the renames.. would be good in the future to separate that out into another diff even if it seems trivial.

This revision is now accepted and ready to land.Dec 28 2023, 5:28 PM

Would've been helpful if there was overview of changes in Summary so I had a more concrete idea of what to expect. Also not a huge deal, but there's a "move" in addition to all of the renames.. would be good in the future to separate that out into another diff even if it seems trivial.

Apologies if this diff was difficult to review! In the future I will do a better job at outlining what was moved in the changes + make these move diffs smaller/more broken up so that it's easier to review

rebase before landing

This revision was landed with ongoing or failed builds.Dec 28 2023, 6:46 PM

Closed by commit rCOMM2d8266808317: [web] cleanup and better organize code for tooltips (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2d8266808317: [web] cleanup and better organize code for tooltips.

Harbormaster completed remote builds in B25389: Diff 35070.Dec 28 2023, 6:56 PM