[web] introduce community header
ClosedPublic
Actions

Authored by ginsu on Dec 29 2023, 12:33 PM.

Details

Reviewers

atul
kamil
rohan

Commits

rCOMM2a82d05adb5e: [web] introduce community header

Summary

This diff puts all the community header components I built in previous diffs and introduces it as the community header component. Just also want to note that this diff also includes some "hacky" logic I introduced to test the two main states of this header. This logic will be removed once I start working on improving the navigation state when navigating communites:

When home/all communities is selected (there should be no community action buttons and the header should say "All communities")

Screenshot 2023-12-29 at 3.36.27 PM.png (1×1 px, 225 KB)

When a community is selected (the name/avatar of the community should be in the header and the community action buttons should be rendered)

Screenshot 2023-12-29 at 3.36.20 PM.png (1×1 px, 320 KB)

Linear task: https://linear.app/comm/issue/ENG-5965/top-bar-when-a-community-is-selected and https://linear.app/comm/issue/ENG-5964/top-bar-when-inboxhome-is-selected

Depends on D10498

Test Plan

Please see the screenshots below

When home/all communities is selected:

Screenshot 2023-12-29 at 3.39.42 PM.png (1×3 px, 809 KB)

When a community is selected:

Screenshot 2023-12-29 at 3.39.37 PM.png (1×3 px, 817 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 29 2023, 12:33 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 12:33 PM

ginsu edited the summary of this revision. (Show Details)Dec 29 2023, 12:40 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil, rohan.

ginsu attached a referenced file: F1013719: Screenshot 2023-12-29 at 3.39.37 PM.png. (Show Details)

ginsu attached a referenced file: F1013718: Screenshot 2023-12-29 at 3.39.42 PM.png. (Show Details)

ginsu attached a referenced file: F1013716: Screenshot 2023-12-29 at 3.36.20 PM.png. (Show Details)

ginsu attached a referenced file: F1013715: Screenshot 2023-12-29 at 3.36.27 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D10498: [web] introduce community header actions.

ginsu added inline comments.Dec 29 2023, 12:43 PM

web/community-header/community-header.react.js
13–15 ↗	(On Diff #35109)	This code will be removed when I work on https://linear.app/comm/issue/ENG-5979/improve-navigation-state-when-navigating-communities
18–20 ↗	(On Diff #35109)	This code will also be improved when I work on https://linear.app/comm/issue/ENG-5979/improve-navigation-state-when-navigating-communities

ginsu edited the summary of this revision. (Show Details)Dec 29 2023, 12:44 PM

Harbormaster completed remote builds in B25410: Diff 35109.Dec 29 2023, 1:00 PM

ginsu requested review of this revision.Dec 29 2023, 1:00 PM

Looks good, but we should try to remove "hard coded" debugging values. Feel free to re-request changes if there's something I'm missing.

web/community-header/community-header.react.js
14–15 ↗	(On Diff #35109)	Eh, not sure how I feel about having these hard coded values (and commented out values) checked into the repo... I think this is a pattern we generally try to avoid. Approaches I've used instead to try to keep git history clean: For simple things, `git stash`ing and `git stash pop`ping to remove/bring back these sorts of debugging changes Have one (or more) `[DO NOT LAND]` commits in my local branch that make these sorts of temporary changes without having to deal with stashing and unstashing. Have to make sure to remove these from stack before landing. CC @ashoat, @tomek, @varun for thoughts
45–50 ↗	(On Diff #35109)	Wouldn't hurt to memoize